Skip to content

Commit

Permalink
Note that {CreateInc,Solib}SymlinkAction may insensitively propagate …
Browse files Browse the repository at this point in the history
…inputs

If re-executed, these actions will not recreate an output which a
downstream action discovered was lost. Rewinding must traverse across
these actions and their artifacts to reach the actions whose
re-execution will recreate such a lost output.

RELNOTES: None.
PiperOrigin-RevId: 229612553
  • Loading branch information
anakanemison authored and Copybara-Service committed Jan 16, 2019
1 parent 7780b75 commit 6269ca7
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -100,5 +100,10 @@ protected String getRawProgressMessage() {
public String getMnemonic() {
return "Symlink";
}

@Override
public boolean mayInsensitivelyPropagateInputs() {
return true;
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -228,4 +228,9 @@ public static String getDynamicLibrarySoname(PathFragment libraryPath,
public boolean shouldReportPathPrefixConflict(ActionAnalysisMetadata action) {
return false; // Always ignore path prefix conflict for the SolibSymlinkAction.
}

@Override
public boolean mayInsensitivelyPropagateInputs() {
return true;
}
}

0 comments on commit 6269ca7

Please sign in to comment.