Skip to content

Commit

Permalink
Remove default -s flag from macOS libtool invocation
Browse files Browse the repository at this point in the history
-s is the default but it's not supported by llvm's libtool replacement
which results in failed links. I don't think we really care about the
specifics here, so since it's the default for most folks we can drop it.
  • Loading branch information
keith committed Feb 14, 2023
1 parent 7227fd4 commit 62aa88e
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -611,7 +611,7 @@ public static ImmutableList<CToolchain.Feature> getLegacyFeatures(
" action: 'c++-link-static-library'",
" flag_group {",
ifLinux(platform, "flag: 'rcsD'"),
ifMac(platform, "flag: '-static'", "flag: '-s'"),
ifMac(platform, "flag: '-static'"),
" }",
" flag_group {",
" expand_if_all_available: 'output_execpath'",
Expand Down

0 comments on commit 62aa88e

Please sign in to comment.