DO NOT IMPORT: Debug invalid absolute paths

bazelbuild · Apr 9, 2023 · 8043408 · 8043408
1 parent e803a09
commit 8043408
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/vfs/BUILD b/src/main/java/com/google/devtools/build/lib/vfs/BUILD
@@ -70,6 +70,7 @@ java_library(
         "//src/main/java/com/google/devtools/build/lib/profiler",
         "//src/main/java/com/google/devtools/build/lib/skyframe/serialization/autocodec",
         "//src/main/java/com/google/devtools/build/lib/util:filetype",
+        "//src/main/java/com/google/devtools/build/lib/util:os",
         "//src/main/java/com/google/devtools/build/skyframe:skyframe-objects",
         "//src/main/java/com/google/devtools/common/options",
         "//third_party:caffeine",

diff --git a/src/main/java/com/google/devtools/build/lib/vfs/RootedPath.java b/src/main/java/com/google/devtools/build/lib/vfs/RootedPath.java
@@ -16,6 +16,7 @@
 import static com.google.common.base.Preconditions.checkArgument;
 
 import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec;
+import com.google.devtools.build.lib.util.OS;
 import com.google.devtools.build.skyframe.SkyKey;
 import java.util.Comparator;
 import javax.annotation.Nullable;
@@ -53,6 +54,11 @@ public final class RootedPath implements Comparable<RootedPath>, FileStateKey {
   @AutoCodec.Instantiator
   @AutoCodec.VisibleForSerialization
   static RootedPath createInternal(Root root, PathFragment rootRelativePath) {
+    if (OS.getCurrent() == OS.WINDOWS && root.isAbsolute() && rootRelativePath.toString()
+        .equals("/")) {
+      throw new IllegalStateException(
+          "Path " + rootRelativePath + ", " + rootRelativePath.getClass());
+    }
     checkArgument(
         rootRelativePath.isAbsolute() == root.isAbsolute(),
         "rootRelativePath: %s root: %s",