Skip to content

Commit

Permalink
Fix a wrong usage of LabelConstants.EXTERNAL_PACKAGE_NAME. PackageIde…
Browse files Browse the repository at this point in the history
…ntifier#getPackagePath is used for constructing artifact paths (primarily derived artifacts), not package names, so LabelConstants.EXTERNAL_PATH_PREFIX is the correct one to use there.

PiperOrigin-RevId: 346772443
  • Loading branch information
Googler authored and copybara-github committed Dec 10, 2020
1 parent 1f9b8ed commit 8a0a227
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ public PathFragment getSourceRoot() {
public PathFragment getPackagePath(boolean siblingRepositoryLayout) {
return repository.isDefault() || repository.isMain() || siblingRepositoryLayout
? pkgName
: LabelConstants.EXTERNAL_PACKAGE_NAME
: LabelConstants.EXTERNAL_PATH_PREFIX
.getRelative(repository.strippedName())
.getRelative(pkgName);
}
Expand Down

0 comments on commit 8a0a227

Please sign in to comment.