Skip to content

Commit

Permalink
[7.2.0] Fix writable sandbox path (#22451)
Browse files Browse the repository at this point in the history
The reverts in 3fddc7f accidentally
replaced `sandboxExecRoot` with `execRoot` in the function that computes
writable directories for sandbox spawn runners.

This issue was observed in
MobileNativeFoundation/rules_xcodeproj#3029.

Closes #22443.

PiperOrigin-RevId: 635383877
Change-Id: I3d74bf78cf97ecd267ba90b68cf1b715850aba27

Commit
b0ed4ca

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
  • Loading branch information
bazel-io and fmeum authored May 20, 2024
1 parent b229d83 commit d31ce86
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ protected ImmutableSet<Path> getWritableDirs(Path sandboxExecRoot, Map<String, S
// On Windows, sandboxExecRoot is actually the main execroot. We will specify
// exactly which output path is writable.
if (OS.getCurrent() != OS.WINDOWS) {
writablePaths.add(execRoot);
writablePaths.add(sandboxExecRoot);
}

String testTmpdir = env.get("TEST_TMPDIR");
Expand Down

0 comments on commit d31ce86

Please sign in to comment.