Skip to content

Commit

Permalink
Add a TODO
Browse files Browse the repository at this point in the history
Change-Id: I92bce9649f9cb91474a835b2ea937b4a740e2bfe
  • Loading branch information
ulfjack committed Aug 19, 2020
1 parent 64253b1 commit e007e02
Showing 1 changed file with 7 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,13 @@ public void afterAnalysis(
}
}

// This is a short-term fix for top-level outputs that are symlinks. Unfortunately, we cannot
// reliably tell after analysis whether actions will create symlinks (the RE protocol allows any
// action to generate and return symlinks), but at least we can handle basic C++ rules with this
// change.
// TODO(ulfjack): I think we should separate downloading files from action execution. That would
// also resolve issues around action invalidation - we currently invalidate actions to trigger
// downloads of top-level outputs when the top-level targets change.
private static void fetchSymlinkDependenciesRecursively(
ActionGraph actionGraph, Set<ActionInput> builder, List<Artifact> inputs) {
for (Artifact input : inputs) {
Expand Down

0 comments on commit e007e02

Please sign in to comment.