Skip to content

Commit

Permalink
Allowlist mac indexing directory
Browse files Browse the repository at this point in the history
We were checking every directory in the sandbox to make sure we keep track of
everything that is stored there. On macOS .DS_Store is a valid
file that shouldn't trigger a crash.

Fixes #23963

RELNOTES:none
PiperOrigin-RevId: 691061742
Change-Id: I085a38fa174cd71682bb599ab3cb1ade0dcd350d
  • Loading branch information
oquenchil authored and copybara-github committed Oct 29, 2024
1 parent 5ce6fa6 commit e297727
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,11 @@
/** This module provides the Sandbox spawn strategy. */
public final class SandboxModule extends BlazeModule {

private static final String MAC_INDEX_FILE = ".DS_Store";

private static final ImmutableSet<String> SANDBOX_BASE_PERSISTENT_DIRS =
ImmutableSet.of(
MAC_INDEX_FILE,
SandboxStash.SANDBOX_STASH_BASE,
SandboxStash.TEMPORARY_SANDBOX_STASH_BASE,
AsynchronousTreeDeleter.MOVED_TRASH_DIR);
Expand Down

0 comments on commit e297727

Please sign in to comment.