Reduce by 3x number of calls to LexerLocation lookups in package seri…

…alization. -- MOS_MIGRATED_REVID=99279879
bazelbuild · Jul 29, 2015 · e4d8482 · e4d8482
1 parent a189640
commit e4d8482
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/packages/PackageSerializer.java b/src/main/java/com/google/devtools/build/lib/packages/PackageSerializer.java
@@ -356,15 +356,17 @@ private static Build.Location serializeLocation(Location location) {
     Build.Location.Builder result = Build.Location.newBuilder();
 
     result.setStartOffset(location.getStartOffset());
-    if (location.getStartLineAndColumn() != null) {
-      result.setStartLine(location.getStartLineAndColumn().getLine());
-      result.setStartColumn(location.getStartLineAndColumn().getColumn());
+    Location.LineAndColumn startLineAndColumn = location.getStartLineAndColumn();
+    if (startLineAndColumn != null) {
+      result.setStartLine(startLineAndColumn.getLine());
+      result.setStartColumn(startLineAndColumn.getColumn());
     }
 
     result.setEndOffset(location.getEndOffset());
-    if (location.getEndLineAndColumn() != null) {
-      result.setEndLine(location.getEndLineAndColumn().getLine());
-      result.setEndColumn(location.getEndLineAndColumn().getColumn());
+    Location.LineAndColumn endLineAndColumn = location.getEndLineAndColumn();
+    if (endLineAndColumn != null) {
+      result.setEndLine(endLineAndColumn.getLine());
+      result.setEndColumn(endLineAndColumn.getColumn());
     }
 
     return result.build();