review comments

bazelbuild · Feb 2, 2024 · ebd3cdb · ebd3cdb
1 parent 3953be8
commit ebd3cdb
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/...main/java/com/google/devtools/build/lib/rules/repository/RepositoryDelegatorFunction.java b/...main/java/com/google/devtools/build/lib/rules/repository/RepositoryDelegatorFunction.java
@@ -666,8 +666,8 @@ private String computeRuleKey(Rule rule, StarlarkSemantics starlarkSemantics) {
       return new Fingerprint()
           .addBytes(RuleFormatter.serializeRule(rule).build().toByteArray())
           .addInt(MARKER_FILE_VERSION)
-          // TODO: Using the hashCode() method for StarlarkSemantics here is technically wrong.
-          //   hashCode() is not guaranteed to be stable across JVM restarts.
+          // TODO: Using the hashCode() method for StarlarkSemantics here is suboptimal as
+          //   it doesn't include any default values.
           .addInt(starlarkSemantics.hashCode())
           .hexDigestAndReset();
     }