Skip to content

Commit

Permalink
Don't evaluate filterKnownInputs() twice for no reason.
Browse files Browse the repository at this point in the history
Possibly we could also check if the return value is empty and just set
state.discoveredInputs to an empty list, but I think a skyframe restart
after this point is unlikely anyway.

RELNOTES: None.
PiperOrigin-RevId: 210170567
  • Loading branch information
Googler authored and Copybara-Service committed Aug 24, 2018
1 parent 9445c1f commit ef0000f
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@ private ActionExecutionValue checkCacheAndExecuteIfNeeded(
if (env.valuesMissing()) {
return null;
}
if (!Iterables.isEmpty(newInputs)) {
if (!metadataFoundDuringActionExecution.isEmpty()) {
// We are in the interesting case of an action that discovered its inputs during
// execution, and found some new ones, but the new ones were already present in the graph.
// We must therefore cache the metadata for those new ones.
Expand Down

0 comments on commit ef0000f

Please sign in to comment.