Skip to content

Commit

Permalink
isable_presubmit
Browse files Browse the repository at this point in the history 
PiperOrigin-RevId: 181491528
  • Loading branch information
Googler authored and Copybara-Service committed Jan 10, 2018
1 parent f596113 commit f6ca788
Showing 1 changed file with 11 additions and 8 deletions.
19 changes: 11 additions & 8 deletions src/main/native/windows/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,19 @@ filegroup(
visibility = ["//src/main/native:__pkg__"],
)

filegroup(
name = "cc-srcs",
srcs = glob([
"*.cc",
"*.h",
]),
)

filegroup(
name = "embedded_tools",
srcs = [
"BUILD",
"file.cc",
"file.h",
"util.cc",
"util.h",
":cc-srcs",
],
visibility = ["//src/main/native:__pkg__"],
)
Expand All @@ -43,10 +48,8 @@ cc_library(

cc_binary(
name = "windows_jni.dll",
srcs = glob([
"*.cc",
"*.h",
]) + [
srcs = [
":cc-srcs",
"//src/main/native:jni.h",
"//src/main/native:jni_md.h",
],
Expand Down

1 comment on commit f6ca788

@pmuetschard
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the messed up change description. Here's what it's supposed to say:

Add the missing JNI cc files to the windows_jni.dll filegroup.
Without these, building windows_jni.dll (for the Android rules, for example) fails with:

ERROR: <...>/external/bazel_tools/src/main/native/windows/BUILD:44:1: output 'external/bazel_tools/src/main/native/windows/windows_jni.ifso' was not created
ERROR: <...>/external/bazel_tools/src/main/native/windows/BUILD:44:1: not all outputs were created or valid

Please sign in to comment.