Implement File.is_symlink.

For symmetry with File.is_directory. Fixes #11209. PiperOrigin-RevId: 690652872 Change-Id: I4e93cb18e2469819cfa46f3c0685376093fc455e
bazelbuild · Oct 28, 2024 · fc60bb6 · fc60bb6
1 parent 57ce6a4
commit fc60bb6
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkCustomCommandLine.java b/src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkCustomCommandLine.java
@@ -1340,6 +1340,11 @@ public boolean isDirectory() {
       return false;
     }
 
+    @Override
+    public boolean isSymlink() {
+      return false;
+    }
+
     @Override
     public String getRunfilesPathString() {
       PathFragment relativePath = execPath.relativeTo(fileset.getExecPath());

diff --git a/src/main/java/com/google/devtools/build/lib/starlarkbuildapi/FileApi.java b/src/main/java/com/google/devtools/build/lib/starlarkbuildapi/FileApi.java
@@ -90,9 +90,21 @@ public interface FileApi extends StarlarkValue {
   @StarlarkMethod(
       name = "is_directory",
       structField = true,
-      doc = "Returns true if this is a directory.")
+      doc =
+          "Returns true if this is a directory. This reflects the type the file was declared as"
+              + " (i.e. ctx.actions.declare_directory), not its type on the filesystem, which might"
+              + " differ.")
   boolean isDirectory();
 
+  @StarlarkMethod(
+      name = "is_symlink",
+      structField = true,
+      doc =
+          "Returns true if this is a directory. This reflects the type the file was declared as"
+              + " (i.e. ctx.actions.declare_symlink), not its type on the filesystem, which might"
+              + " differ.")
+  boolean isSymlink();
+
   @StarlarkMethod(
       name = "short_path",
       structField = true,