Make C++ runfiles library build with -Werror=shadow (#16869)

Fixes #16796

Closes #16801.

PiperOrigin-RevId: 491349584
Change-Id: I7498d9343a5d7849e2d726fbc1e5447178c39d79

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>

tools/cpp/runfiles/runfiles_src.h

@@ -195,12 +195,12 @@ class Runfiles {
       std::map<std::string, std::string> runfiles_map, std::string directory,
       std::map<std::pair<std::string, std::string>, std::string> repo_mapping,
       std::vector<std::pair<std::string, std::string> > envvars,
-      std::string source_repository_)
+      std::string source_repository)
       : runfiles_map_(std::move(runfiles_map)),
         directory_(std::move(directory)),
         repo_mapping_(std::move(repo_mapping)),
         envvars_(std::move(envvars)),
-        source_repository_(std::move(source_repository_)) {}
+        source_repository_(std::move(source_repository)) {}
   Runfiles(const Runfiles&) = delete;
   Runfiles(Runfiles&&) = delete;
   Runfiles& operator=(const Runfiles&) = delete;