Skip to content

Commit

Permalink
Remove default -s flag from macOS libtool invocation
Browse files Browse the repository at this point in the history
-s is the default but it's not supported by llvm's libtool replacement which results in failed links. I don't think we really care about the specifics here, so since it's the default for most folks we can drop it.

Closes #17489.

PiperOrigin-RevId: 511121405
Change-Id: Id0b52f960072100d232fdbf5461dec068c8e3edf
  • Loading branch information
keith authored and bazel-io committed Sep 8, 2023
1 parent 3aea7d7 commit fe3bc58
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -631,7 +631,7 @@ public static ImmutableList<CToolchain.Feature> getLegacyFeatures(
" action: 'c++-link-static-library'",
" flag_group {",
ifLinux(platform, "flag: 'rcsD'"),
ifMac(platform, "flag: '-static'", "flag: '-s'"),
ifMac(platform, "flag: '-static'"),
" }",
" flag_group {",
" expand_if_all_available: 'output_execpath'",
Expand Down

0 comments on commit fe3bc58

Please sign in to comment.