-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cc_import
complains about some versioned .so files in 5.0
#14289
Milestone
Comments
Actually, it's already fixed by 23d0969. |
Do you think cherrypicking that into 5.0 is enough to fix this? cc @erenon |
philsc
pushed a commit
to philsc/bazel
that referenced
this issue
Nov 17, 2021
Consider libfoo-1.0.so.1.0 valid. Do not fail if the name does not contain a '.', return False instead. (cherry picked from commit 23d0969) Fixes bazelbuild#14289. Closes bazelbuild#14021.
Probably yes. |
I created PR #14290 to cherry-pick the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the problem / feature request:
Upgrading from 4.2.1 to 5.0.0rc2 results in this error for me:
This is what
external/system_libs/BUILD.bazel
looks like:Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
Write a
cc_import
target with a shared library that contains a.
in the non-extension part of the filename.What operating system are you running Bazel on?
Ubuntu 18.04 x86_64
What's the output of
bazel info release
?If
bazel info release
returns "development version" or "(@non-git)", tell us how you built Bazel.Have you found anything relevant by searching the web?
I found this patch that removed the Starlark implementation of
cc_import
: f756442It's a bit frustrating though that the commit message gives no justification or reasoning for this.
Any other information, logs, or outputs that you want to share?
N/A
The text was updated successfully, but these errors were encountered: