Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--incompatible_remote_build_event_upload_respect_no_cache stops working when building an alias #14456

Closed
brentleyjones opened this issue Dec 21, 2021 · 1 comment
Assignees
Labels
P1 I'll work on this now. (Assignee required) team-Remote-Exec Issues and PRs for the Execution (Remote) team type: bug

Comments

@brentleyjones
Copy link
Contributor

Description of the problem / feature request:

When using --incompatible_remote_build_event_upload_respect_no_cache and building an alias, bep-referenced items are uploaded to the remote cache even with --noremote_upload_local_results. When building the aliased target directly they are correctly excluded from upload.

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

This will exclude blobs from upload:

$ git clone git@github.com:bazelbuild/rules_apple.git
$ cd rules_apple
$ env USE_BAZEL_VERSION=5.0.0rc3 bazelisk build --remote_cache=grpcs://remote.buildbuddy.io --bes_backend=grpcs://remote.buildbuddy.io --bes_results_url=https://app.buildbuddy.io/invocation/ --incompatible_remote_build_event_upload_respect_no_cache --noremote_upload_local_results //examples/iOS/StickersApp

While this won't:

$ echo '
alias(
    name = "through_alias",
    actual = "//examples/ios/StickersApp",
)' >> BUILD
$ env USE_BAZEL_VERSION=5.0.0rc3 bazelisk build --remote_cache=grpcs://remote.buildbuddy.io --bes_backend=grpcs://remote.buildbuddy.io --bes_results_url=https://app.buildbuddy.io/invocation/ --incompatible_remote_build_event_upload_respect_no_cache --noremote_upload_local_results //:through_alias

What operating system are you running Bazel on?

macOS 12.0.1

What's the output of bazel info release?

release 5.0 rc3

Have you found anything relevant by searching the web?

#14338

@brentleyjones
Copy link
Contributor Author

cc @coeuvre

@coeuvre coeuvre self-assigned this Dec 21, 2021
@coeuvre coeuvre added P1 I'll work on this now. (Assignee required) team-Remote-Exec Issues and PRs for the Execution (Remote) team type: bug labels Dec 21, 2021
coeuvre added a commit to coeuvre/bazel that referenced this issue Dec 23, 2021
…he` working with alias.

Fixes bazelbuild#14456.

Closes bazelbuild#14461.

PiperOrigin-RevId: 417637635
Wyverald pushed a commit that referenced this issue Dec 23, 2021
* Remote: Don't upload BES referenced blobs to disk cache.

Fixes #14435.

Closes #14451.

PiperOrigin-RevId: 417629899

* Remote: Make `--incompatible_remote_build_event_upload_respect_no_cache` working with alias.

Fixes #14456.

Closes #14461.

PiperOrigin-RevId: 417637635

* Remote: Make --incompatible_remote_build_event_upload_respect_no_cache working with --incompatible_remote_results_ignore_disk.

Fixes #14463.

Closes #14468.

PiperOrigin-RevId: 417984062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 I'll work on this now. (Assignee required) team-Remote-Exec Issues and PRs for the Execution (Remote) team type: bug
Projects
None yet
2 participants