Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test coverage support for android_local_test targets #15827

Closed
Bencodes opened this issue Jul 6, 2022 · 0 comments
Closed

Test coverage support for android_local_test targets #15827

Bencodes opened this issue Jul 6, 2022 · 0 comments
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Android Issues for Android team type: feature request

Comments

@Bencodes
Copy link
Contributor

Bencodes commented Jul 6, 2022 •
edited
Loading

Description of the feature request:

Test coverage support for android_local_test targets

What underlying problem are you trying to solve with this feature?

The current implementation for android_local_test does not support testing with coverage and just errors out with a throwWithRuleError error.

This can be reproduced by running bazel coverage //:android_test on an Android test target.
@Bencodes Bencodes mentioned this issue Jul 8, 2022
Closed
@ahumesky ahumesky added P2 We'll consider working on this in future. (Assignee optional) and removed untriaged labels Oct 25, 2022
copybara-service bot pushed a commit that referenced this issue Feb 10, 2023
@Bencodes @copybara-github
Add test coverage support to android_local_test
6bd2cc3 
Adding test coverage support to `android_local_test`.

#15827

Closes #15840.

RELNOTES: Adds coverage metric support to android_local_test
PiperOrigin-RevId: 508549884
Change-Id: I6977efa51ca1c7a6df1f776fe1a326d07989a185
ted-xie pushed a commit to ted-xie/bazel that referenced this issue Feb 10, 2023
@Bencodes @ted-xie
Add test coverage support to android_local_test
7926da6 
Adding test coverage support to `android_local_test`.

bazelbuild#15827

Closes bazelbuild#15840.

RELNOTES: Adds coverage metric support to android_local_test
PiperOrigin-RevId: 508549884
Change-Id: I6977efa51ca1c7a6df1f776fe1a326d07989a185
@ted-xie ted-xie mentioned this issue Feb 10, 2023
Merged
hvadehra pushed a commit that referenced this issue Feb 14, 2023
@Bencodes @hvadehra
Add test coverage support to android_local_test
aedb8f0 
Adding test coverage support to `android_local_test`.

#15827

Closes #15840.

RELNOTES: Adds coverage metric support to android_local_test
PiperOrigin-RevId: 508549884
Change-Id: I6977efa51ca1c7a6df1f776fe1a326d07989a185
ted-xie pushed a commit to ted-xie/bazel that referenced this issue Feb 23, 2023
@Bencodes @ted-xie
Add test coverage support to android_local_test
2f847a4 
Adding test coverage support to `android_local_test`.

bazelbuild#15827

Closes bazelbuild#15840.

RELNOTES: Adds coverage metric support to android_local_test
PiperOrigin-RevId: 508549884
Change-Id: I6977efa51ca1c7a6df1f776fe1a326d07989a185
ted-xie pushed a commit to ted-xie/bazel that referenced this issue Mar 1, 2023
@Bencodes @ted-xie
Add test coverage support to android_local_test
0ca38bb 
Adding test coverage support to `android_local_test`.

bazelbuild#15827

Closes bazelbuild#15840.

RELNOTES: Adds coverage metric support to android_local_test
PiperOrigin-RevId: 508549884
Change-Id: I6977efa51ca1c7a6df1f776fe1a326d07989a185
ted-xie pushed a commit to ted-xie/bazel that referenced this issue Mar 1, 2023
@Bencodes @ted-xie
Add test coverage support to android_local_test
b84fab1 
Adding test coverage support to `android_local_test`.

bazelbuild#15827

Closes bazelbuild#15840.

RELNOTES: Adds coverage metric support to android_local_test
PiperOrigin-RevId: 508549884
Change-Id: I6977efa51ca1c7a6df1f776fe1a326d07989a185
@Bencodes Bencodes closed this as completed Mar 2, 2023
ted-xie pushed a commit to ted-xie/bazel that referenced this issue Mar 13, 2023
@Bencodes @ted-xie
Add test coverage support to android_local_test
f0fb0f8 
Adding test coverage support to `android_local_test`.

bazelbuild#15827

Closes bazelbuild#15840.

RELNOTES: Adds coverage metric support to android_local_test
PiperOrigin-RevId: 508549884
Change-Id: I6977efa51ca1c7a6df1f776fe1a326d07989a185
ShreeM01 added a commit that referenced this issue Mar 13, 2023
@ted-xie @tjgq
@Bencodes @ShreeM01
[6.2.0]Add test coverage support to android_local_test (#17467)
b874e5f 
* Propagate runfiles for singlejar.

Since the singlejar toolchain attribute is currently defined as a single file and carried around as an Artifact instead of a FilesToRunProvider, it's not possible to implement it as a wrapper script that dispatches to an actual implementation somewhere in its runfiles. This would be useful to experiment with cross-platform action sharing.

PiperOrigin-RevId: 492487124
Change-Id: Ib0f80314eae09bd865b3f31a4180bf068833cdf4

* Add test coverage support to android_local_test

Adding test coverage support to `android_local_test`.

#15827

Closes #15840.

RELNOTES: Adds coverage metric support to android_local_test
PiperOrigin-RevId: 508549884
Change-Id: I6977efa51ca1c7a6df1f776fe1a326d07989a185

---------

Co-authored-by: Googler <tjgq@google.com>
Co-authored-by: Benjamin Lee <ben@ben.cm>
Co-authored-by: kshyanashree <109167932+kshyanashree@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Android Issues for Android team type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Bencodes @ahumesky @sgowroji