-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ship an embedded Jvm or installer #1666
Comments
Adding Helen also, I think we also need to evaluate the benefit of doing so. I am pretty sure we can do it with putting an engineer one month on it. The underlying maintenance is less clear. Probably around 1 day per Java update (so a day per month I would say) is a big overestimation. I'd rather we work on that if that's higher priority that other thing. We agree it is nice to do, just not clear how nice. |
(note: those costs are rough estimation of the engineering time, we probably needs to speak to legal about what we can do exactly, though this might be covered by the recent fix on GPL with classpath exception code). |
/cc @philwo fyi |
Reassigning priority so we can get rid of the JDK 7 build. Seems like the perfect solution for it. Philip has agreed to investigate further. |
The feature is complete, integrated with our build process and in code review & pending final verification on Windows now. |
It would need to integrate with our release pipeline too, but I guess this is just another target to build |
Yes, the current approach is that this is just another target that we can build (//src:bazel_with_jdk instead of //src:bazel). :) |
I don't think I will have time for it soon enough, but just adding the target in //scripts/package to build the deb and .sh with jdk and then reference them in scripts/ci/build.sh for them to be pushed should be enough. |
Just as an input - we have a JDK for every platform in our repo just because the dependency on Java. Would also greatly appreciate, if that would be solved automagically. |
We've gotten feedback that the dependency on Java makes it unnecessarily harder to install Bazel, and we should consider if bundling a Jvm or triggering a Jvm install from our installer would be workable options. What are our options here?
The text was updated successfully, but these errors were encountered: