Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.5 #2692

Closed
hermione521 opened this issue Mar 16, 2017 · 53 comments
Closed

Release 0.5 #2692

hermione521 opened this issue Mar 16, 2017 · 53 comments
Assignees
Labels
P1 I'll work on this now. (Assignee required) type: process
Milestone

Comments

@hermione521
Copy link
Contributor

Quote from last release manager: hopefully this time it can be 0.5!

@hermione521 hermione521 added category: misc > release / binary P1 I'll work on this now. (Assignee required) type: process labels Mar 16, 2017
@hermione521 hermione521 added this to the 0.5 milestone Mar 16, 2017
@meteorcloudy
Copy link
Member

In https://bazel-review.googlesource.com/#/c/9461/, bazel_bootstrap_distfile_test is disabled temporarily on Windows due to #2708

We need to test it manually before release 0.5

@hlopko
Copy link
Member

hlopko commented Mar 21, 2017

Thanks for letting me know!

@meteorcloudy
Copy link
Member

Please cherry-pick #2862 if it's not in 0.5. Our users depend on it.

@buchgr
Copy link
Contributor

buchgr commented Apr 26, 2017

How is it decided / Who decides what gets into 0.5?

Having bcd2355 in 0.5 would also be nice, as this is a blocker for google/protobuf.

@hlopko
Copy link
Member

hlopko commented Apr 26, 2017

It depends on when we will do the cut. We still wait for #1666, then we'll wait for a green ci, then we will do the cut. So bcd2355 will definitely be in the 0.5.

@buchgr
Copy link
Contributor

buchgr commented Apr 26, 2017

Makes sense. thanks @mhlopko :)

@damienmg
Copy link
Contributor

damienmg commented May 1, 2017

FTR 1fb094e needs to be in the release (regression detected inside google)

@damienmg
Copy link
Contributor

damienmg commented May 3, 2017

I suggest cutting the release at f3ae88e since there is only a handful of breakage that needs investigation and no clear regression so far. We can cherry-pick change needed to stabilize the release.

@damienmg
Copy link
Contributor

damienmg commented May 3, 2017

Note that the release testing is not very good so it would be good to run the docker test on a workstation and send the release branch as a gerrit code review to get bazel test coverage for it.

@buchgr
Copy link
Contributor

buchgr commented May 3, 2017

@laszlocsomor just informed me that he found 4 very serious bugs in his protobuf patch [1]. We included this patch when updating protobuf in 2b49f67. So we should not include the updated protobuf in the new release (or at least not without updating to laszlo's latest patch).

It looks like the protobuf updated happened before f3ae88e but after 1fb094e.

[1] protocolbuffers/protobuf#2969

@rahul-malik
Copy link
Contributor

@damienmg - Is 0.5 going to include #1666?

This would be very helpful for distribution of Bazel updates to our team.

@damienmg
Copy link
Contributor

damienmg commented May 3, 2017 via email

@buchgr
Copy link
Contributor

buchgr commented May 3, 2017

@damienmg :-( ... let's talk with laszo tomorrow before the release.

@laszlocsomor
Copy link
Contributor

4 very serious bugs

The situation isn't so severe. See the commit message for full context: protocolbuffers/protobuf@c4c8806

@abergmeier-dsfishlabs
Copy link
Contributor

abergmeier-dsfishlabs commented May 4, 2017

The situation isn't so severe.

That might be true.
Be aware that due to increasingly fewer Bazel releases/months people might stay on that release for quite some time.
What I am asking is probably - will there be 0.5.x before 0.6?

@damienmg
Copy link
Contributor

damienmg commented May 4, 2017 via email

bazel-io pushed a commit that referenced this issue May 4, 2017
To be cherry-picked for #2692.

PiperOrigin-RevId: 155063394
@rahul-malik
Copy link
Contributor

Is there a plan to have a release candidate available before officially shipping 5.0 to incorporate feedback / fix issues before the final release?

@damienmg
Copy link
Contributor

damienmg commented May 4, 2017 via email

hlopko pushed a commit that referenced this issue May 4, 2017
To be cherry-picked for #2692.

PiperOrigin-RevId: 155063394
bazel-io pushed a commit that referenced this issue May 4, 2017
to ensure outputs from any previous local builds are discarded.

To cherry-pick for #2692.

Fixes #2941

PiperOrigin-RevId: 155089391
@hlopko
Copy link
Member

hlopko commented May 5, 2017

Creating RC3, for the info:
base: f3ae88e
cherrypicks:
c58ba09
0acead4
d0242ce
d953ca8

hlopko pushed a commit that referenced this issue May 5, 2017
To be cherry-picked for #2692.

PiperOrigin-RevId: 155063394
hlopko pushed a commit that referenced this issue May 5, 2017
to ensure outputs from any previous local builds are discarded.

To cherry-pick for #2692.

Fixes #2941

PiperOrigin-RevId: 155089391
hlopko pushed a commit that referenced this issue May 23, 2017
Instead just mark it as a default installer when there is
no installer with a bundled JDK.

Fixes #2969
To be cherry-picked for #2692.

PiperOrigin-RevId: 155483548
hlopko pushed a commit that referenced this issue May 23, 2017
Closes #2959.
Ping #2692 for cherry-picking into Bazel 0.5.0.

PiperOrigin-RevId: 155357560
@hlopko
Copy link
Member

hlopko commented May 23, 2017

Please celebrate another rc :) Including big note and 3b08f77 :)

@meteorcloudy
Copy link
Member

Thank you, Marcel!! \o/

@ittaiz
Copy link
Member

ittaiz commented May 23, 2017

@iirina will 7e91ad6 get in 0.5.0?

@iirina
Copy link
Contributor

iirina commented May 23, 2017

It wasn't planned for, but if you have a strong opinion about it being included you can ask @mhlopko if he would create another RC. But since this is already the 8th RC and a release should be done soon, I'm not very sure about it.

@philwo
Copy link
Member

philwo commented May 23, 2017

If you do another round of cherry-picks, please pick this in: db5e06a

I promised it to a user here: https://stackoverflow.com/questions/43849651/how-to-lock-down-the-bazel-filesystem-sandbox/43897863#43897863

But, to be honest, I think we should call it a day and release this if it's stable and then quickly do a 0.5.1 instead of dragging this out even longer...

@ittaiz
Copy link
Member

ittaiz commented May 23, 2017

@philwo @iirina realistically when can we expect 0.5.1?
If 0.5.1 can be cut in a few days (week or two) then of course no objection.
If it's a month from now then I'd say pretty please :)

@damienmg
Copy link
Contributor

damienmg commented May 23, 2017 via email

@petemounce
Copy link
Contributor

petemounce commented May 23, 2017

I tried to push rc7 (#2692 (comment)), but it doesn't appear to have arrived in the bucket yet? That is, https://storage.googleapis.com/bazel/0.5.0/rc7/index.html -> NoSuchKey.

@hlopko
Copy link
Member

hlopko commented May 23, 2017

Oh sorry about that, I messed 7 up and didn't push it, and only realized so when I pushed 8... So there's no RC 7...

@petemounce
Copy link
Contributor

Ah, no worries. Thanks.

https://chocolatey.org/packages/bazel/0.5.0-rc8 has been published.

@iirina iirina mentioned this issue May 23, 2017
@philwo
Copy link
Member

philwo commented May 24, 2017

@mhlopko A release critical bug was found in our internal version in which the linux-sandbox is completely non functional (can't even execute /bin/true), cf. b/62022773. The bug does not seem to affect Bazel 0.5.0, but please let me verify this manually before finally releasing Bazel 0.5.0. :( Sorry for the mess...

Amazingly, the bug is present in Bazel's HEAD and causes Bazel to automatically fall back to non-sandboxed execution, but nothing in our CI is catching it. It's totally green and saying that sandboxed tests are passing - WTF.

@damienmg
Copy link
Contributor

IIUC from the internal bug, the causing CL is not in the release branch. All the test from Google teams have come back green, no regression reported by external users, seems like we are good to push 0.5.0rc9 as the 0.5.0 release tomorrow?

@petemounce
Copy link
Contributor

https://chocolatey.org/packages/bazel/0.5.0-rc9 has been published.

@philwo
Copy link
Member

philwo commented May 26, 2017

Damien: OK, I think we can then go ahead with the release.

@damienmg
Copy link
Contributor

This was released but there is a regression: #3063 :(

Anyway closing this bug.

damienmg added a commit that referenced this issue May 26, 2017
To be cherry-picked for #2692.

PiperOrigin-RevId: 155063394
damienmg pushed a commit that referenced this issue May 26, 2017
to ensure outputs from any previous local builds are discarded.

To cherry-pick for #2692.

Fixes #2941

PiperOrigin-RevId: 155089391
damienmg added a commit that referenced this issue May 26, 2017
We might be using more environment variables that the actual list.

To be cherry-picked for #2692.

Fixes #2953.

Change-Id: I9b926d48e14b2c65822770ab46f6507a5303c3d3
PiperOrigin-RevId: 155387369
damienmg added a commit that referenced this issue May 26, 2017
Instead just mark it as a default installer when there is
no installer with a bundled JDK.

Fixes #2969
To be cherry-picked for #2692.

PiperOrigin-RevId: 155483548
damienmg pushed a commit that referenced this issue May 26, 2017
Closes #2959.
Ping #2692 for cherry-picking into Bazel 0.5.0.

PiperOrigin-RevId: 155357560
@petemounce
Copy link
Contributor

https://chocolatey.org/packages/bazel/0.5.0 is published, awaiting automated review.

hlopko pushed a commit that referenced this issue May 31, 2017
To be cherry-picked for #2692.

PiperOrigin-RevId: 155063394
hlopko pushed a commit that referenced this issue May 31, 2017
to ensure outputs from any previous local builds are discarded.

To cherry-pick for #2692.

Fixes #2941

PiperOrigin-RevId: 155089391
hlopko pushed a commit that referenced this issue May 31, 2017
We might be using more environment variables that the actual list.

To be cherry-picked for #2692.

Fixes #2953.

Change-Id: I9b926d48e14b2c65822770ab46f6507a5303c3d3
PiperOrigin-RevId: 155387369
hlopko pushed a commit that referenced this issue May 31, 2017
Instead just mark it as a default installer when there is
no installer with a bundled JDK.

Fixes #2969
To be cherry-picked for #2692.

PiperOrigin-RevId: 155483548
hlopko pushed a commit that referenced this issue May 31, 2017
Closes #2959.
Ping #2692 for cherry-picking into Bazel 0.5.0.

PiperOrigin-RevId: 155357560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 I'll work on this now. (Assignee required) type: process
Projects
None yet
Development

No branches or pull requests