homebrew build does not work for 0.5rc3

[damienmg]

Output:

==> Downloading https://storage.googleapis.com/bazel/0.5/rc3/bazel-0.5rc3-dist.z
######################################################################## 100.0%
Warning: Cannot verify integrity of bazel-0.5rc3.zip
A checksum was not provided for this resource
For your reference the SHA256 is: 54d6948e603c0fb3574d14bb8049afb915026ea171fd8b0153acc05798a5b089
==> ./compile.sh
Last 15 lines from /Users/dmarting/Library/Logs/Homebrew/bazel/01.compile.sh:
  (cd /tmp/bazel_szWzhipD/out/execroot/bazel-20170505-28227-1peswy3 && \
  exec env - \
    PATH=/Library/Java/JavaVirtualMachines/jdk1.8.0_112.jdk/Contents/Home/bin:/Users/dmarting/homebrew/Library/Homebrew/shims/super:/usr/bin:/bin:/usr/sbin:/sbin \
    PWD=/proc/self/cwd \
    TMPDIR=/tmp \
  external/local_config_cc/cc_wrapper.sh -U_FORTIFY_SOURCE -fstack-protector -Wall -Wthread-safety -Wself-assign -Wunused-but-set-parameter -Wno-free-nonheap-object -fcolor-diagnostics -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections -fdata-sections '-std=c++0x' -MD -MF bazel-out/local-opt/bin/third_party/protobuf/3.2.0/_objs/protobuf_lite/third_party/protobuf/3.2.0/src/google/protobuf/generated_message_util.d '-frandom-seed=bazel-out/local-opt/bin/third_party/protobuf/3.2.0/_objs/protobuf_lite/third_party/protobuf/3.2.0/src/google/protobuf/generated_message_util.o' -iquote . -iquote bazel-out/local-opt/genfiles -iquote external/bazel_tools -iquote bazel-out/local-opt/genfiles/external/bazel_tools -isystem third_party/protobuf/3.2.0/src -isystem bazel-out/local-opt/genfiles/third_party/protobuf/3.2.0/src -isystem external/bazel_tools/tools/cpp/gcc3 -DHAVE_PTHREAD -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -Wno-unused-function -fno-canonical-system-headers -Wno-builtin-macro-redefined '-D__DATE__="redacted"' '-D__TIMESTAMP__="redacted"' '-D__TIME__="redacted"' -c third_party/protobuf/3.2.0/src/google/protobuf/generated_message_util.cc -o bazel-out/local-opt/bin/third_party/protobuf/3.2.0/_objs/protobuf_lite/third_party/protobuf/3.2.0/src/google/protobuf/generated_message_util.o): com.google.devtools.build.lib.shell.BadExitStatusException: Process exited with status 1.
/Users/dmarting/homebrew/Library/Homebrew/shims/super/clang:34:in `escape': no implicit conversion of nil into String (TypeError)
	from /Users/dmarting/homebrew/Library/Homebrew/shims/super/clang:34:in `initialize'
	from /Users/dmarting/homebrew/Library/Homebrew/shims/super/clang:363:in `new'
	from /Users/dmarting/homebrew/Library/Homebrew/shims/super/clang:363:in `<main>'
Target //src:bazel failed to build
INFO: Elapsed time: 8.148s, Critical Path: 0.19s

ERROR: Could not build Bazel

git diff:

diff --git a/Formula/bazel.rb b/Formula/bazel.rb
index b847cf5..4f1aa25 100644
--- a/Formula/bazel.rb
+++ b/Formula/bazel.rb
@@ -1,8 +1,9 @@
 class Bazel < Formula
   desc "Google's own build tool"
   homepage "https://bazel.build/"
-  url "https://github.com/bazelbuild/bazel/releases/download/0.4.5/bazel-0.4.5-dist.zip"
-  sha256 "2b737be42678900470ae9e48c975ac5b2296d9ae23c007bf118350dbe7c0552b"
+  url "https://storage.googleapis.com/bazel/0.5/rc3/bazel-0.5rc3-dist.zip"
+# https://github.com/bazelbuild/bazel/releases/download/0.4.5/bazel-0.4.5-dist.zip"
+  # sha256 "2b737be42678900470ae9e48c975ac5b2296d9ae23c007bf118350dbe7c0552b"
 
   bottle do
     cellar :any_skip_relocation

[damienmg]

(note that bootstrapping outside of homebrew works no problem)

[damienmg]

Confirmed on my other laptop. Same error.

[philwo]

Seems like a bug in Homebrew's clang wrapper...

[philwo]

The failing line seems to be this:
@keg_regex = %r[(#{Regexp.escape(opt)}|#{Regexp.escape(cellar)})/([\w+-.@]+)]

I guess either opt or cellar are nil, when they should be a String. opt is defined as @opt = ENV["HOMEBREW_OPT"] and cellar as @cellar = ENV["HOMEBREW_CELLAR"].

Does that help somehow?

[damienmg]

Yes that means that we strip out HOMEBREW_OPT or HOMEBREW_CELLAR. This was my first idea too that we stopped shipping some environment variable. I would suspect a change by Nicolas on cc_configure.bzl, let me confirm that.

[damienmg]

Ok this is due to a weird bug:

cc_configure doesn't see the whole environment, just the subset from the environ variable.

[damienmg]

I could not repro on Linux with:

[dmarting@trantor] /tmp/WORKSPACE$ cat test.bzl 
def _impl(rctx):
  print(rctx.os.environ)
  rctx.file("BUILD", "")


test_rule = repository_rule(
  environ=["TEST"],
  implementation=_impl,
)
[dmarting@trantor] /tmp/WORKSPACE$ cat WORKSPACE 
load("//:test.bzl", "test_rule")
test_rule(name = "test")
[dmarting@trantor] /tmp/WORKSPACE$ cat BUILD 
[dmarting@trantor] /tmp/WORKSPACE$ 

So either this is a darwin bug, something specific to homebrew env or in cc_configure.

[damienmg]

Ok cannot repro with that example in the homebrew env, so cc_configure looks like more and more like a suspect.

[damienmg]

Of course, the issue is that we do not pass all environment variable during bootstrap, we should fix that.