Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set output_files on proto_lang_toolchain rules #18623

Open
1 of 4 tasks
comius opened this issue Jun 9, 2023 · 0 comments
Open
1 of 4 tasks

Set output_files on proto_lang_toolchain rules #18623

comius opened this issue Jun 9, 2023 · 0 comments
Assignees
@comius
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Rules-API API for writing rules/aspects: providers, runfiles, actions, artifacts

Comments

@comius
Copy link
Contributor

comius commented Jun 9, 2023 •
edited
Loading

With commit 482d2be and additional information on proto_lang_toolchain rule, proto_common.compile doesn't need to set plugin_output parameter.

  • Cherry-pick commit on minor Bazel release
  • Wait Bazel LTS release
  • Update proto_lang_toolchain rules
  • Update proto_common.compile calls
@comius comius added P2 We'll consider working on this in future. (Assignee optional) team-Rules-API API for writing rules/aspects: providers, runfiles, actions, artifacts labels Jun 9, 2023
@comius comius self-assigned this Jun 9, 2023
copybara-service bot pushed a commit that referenced this issue Jun 9, 2023
@comius @copybara-github
Compute the value of plugin_output from proto_info
482d2be 
Additional information is needed whether protoc generates a single file or multiple files.

Add output_files to proto_lang_toolchain (enum "single","multiple") and propagate it through ProtoLangToolchainInfo.

Add experimental_output_files to proto_common.compile, that can override the value, for faster migration path.

When the value is set, automatically compute plugin_output.

When the (legacy) plugin_output is not set to a file, set it automatically to correct directory.

AI: Cherry-pick this change to Bazel minor release and follow up with updates to proto_lang_toolchain.

Fixes: #18263
Tracking issue: #18623
PiperOrigin-RevId: 539047857
Change-Id: Id5c3f48f02ad245bee90eb113d5ba4f681c650ac
copybara-service bot pushed a commit that referenced this issue Jun 20, 2023
@comius @copybara-github
Rollforward of 482d2be: Compute the value of plugin_output from proto…
4d14d3f 
…_info

NEW: don't try to compute plugin_output automatically

Additional information is needed whether protoc generates a single file or multiple files.

Add output_files to proto_lang_toolchain (enum "single","multiple") and propagate it through ProtoLangToolchainInfo.

Add experimental_output_files to proto_common.compile, that can override the value, for faster migration path.

When the value is set, automatically compute plugin_output.

When the (legacy) plugin_output is not set to a file, set it automatically to correct directory.

AI: Cherry-pick this change to Bazel minor release and follow up with updates to proto_lang_toolchain.

Fixes: #18263
Tracking issue: #18623
PiperOrigin-RevId: 541964181
Change-Id: Ie4b4792287723798ffdd4047562d62eb05d1b731
traversaro pushed a commit to traversaro/bazel that referenced this issue Jun 24, 2023
@comius @traversaro
Compute the value of plugin_output from proto_info
e1aed90 
Additional information is needed whether protoc generates a single file or multiple files.

Add output_files to proto_lang_toolchain (enum "single","multiple") and propagate it through ProtoLangToolchainInfo.

Add experimental_output_files to proto_common.compile, that can override the value, for faster migration path.

When the value is set, automatically compute plugin_output.

When the (legacy) plugin_output is not set to a file, set it automatically to correct directory.

AI: Cherry-pick this change to Bazel minor release and follow up with updates to proto_lang_toolchain.

Fixes: bazelbuild#18263
Tracking issue: bazelbuild#18623
PiperOrigin-RevId: 539047857
Change-Id: Id5c3f48f02ad245bee90eb113d5ba4f681c650ac
@comius comius mentioned this issue Jun 26, 2023
Merged
comius added a commit to comius/bazel that referenced this issue Jun 26, 2023
@comius
Rollforward of bazelbuild@482d2be: Compute the value of plugin_output…
c73f70e 
… from proto_info

NEW: don't try to compute plugin_output automatically

Additional information is needed whether protoc generates a single file or multiple files.

Add output_files to proto_lang_toolchain (enum "single","multiple") and propagate it through ProtoLangToolchainInfo.

Add experimental_output_files to proto_common.compile, that can override the value, for faster migration path.

When the value is set, automatically compute plugin_output.

When the (legacy) plugin_output is not set to a file, set it automatically to correct directory.

AI: Cherry-pick this change to Bazel minor release and follow up with updates to proto_lang_toolchain.

Fixes: bazelbuild#18263
Tracking issue: bazelbuild#18623
PiperOrigin-RevId: 541964181
Change-Id: Ie4b4792287723798ffdd4047562d62eb05d1b731
iancha1992 added a commit that referenced this issue Jul 12, 2023
@comius @iancha1992
[6.3.0] Rollforward of https://github.com/bazelbuild/bazel/commit/482…
e8ac967 
…d2be27ab… (#18773)

* Rollforward of 482d2be: Compute the value of plugin_output from proto_info

NEW: don't try to compute plugin_output automatically

Additional information is needed whether protoc generates a single file or multiple files.

Add output_files to proto_lang_toolchain (enum "single","multiple") and propagate it through ProtoLangToolchainInfo.

Add experimental_output_files to proto_common.compile, that can override the value, for faster migration path.

When the value is set, automatically compute plugin_output.

When the (legacy) plugin_output is not set to a file, set it automatically to correct directory.

AI: Cherry-pick this change to Bazel minor release and follow up with updates to proto_lang_toolchain.

Fixes: #18263
Tracking issue: #18623
PiperOrigin-RevId: 541964181
Change-Id: Ie4b4792287723798ffdd4047562d62eb05d1b731

* Fix tests

---------

Co-authored-by: Ian (Hee) Cha <heec@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@comius comius

Labels
P2 We'll consider working on this in future. (Assignee optional) team-Rules-API API for writing rules/aspects: providers, runfiles, actions, artifacts
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@comius