same `module_extension` name in different bzl files could not be resolved while using bzlmod in bazel 6.3.1 #19155

xiemotongye · 2023-08-03T09:43:23Z

Description of the bug:

We're using bzlmod.
This is a part of MODULE.bazel, which works fine in bazel 6.2.1.

a_ext = use_extension("//path/to/A:A.bzl", "my_ext")
use_repo(a_ext, "abc")
b_ext = use_extension("//path/to/B:B.bzl", "my_ext")
use_repo(b_ext, "xyz")

When I updated bazel to 6.3.1, there was an error in analysis phase.

ERROR: /my/workspace/library_path/BUILD:4:13: no such package '@_main~my_ext~2~xyz//':
The repository '@_main~my_ext~2~xyz' could not be resolved:
Repository '@_main~my_ext~2~xyz' is not defined and referenced by '//library_path:library_name'
ERROR: Analysis of target '//my_path:my_target' failed; build aborted:

It seems that in bazel 6.2.1, if there is a same module_extension name in different bzl files, the second one will be named as @_main~my_ext2~xyz in external directory. But in bazel 6.3.1, it seems that bazel is tring to find a module named as @_main~my_ext~2~xyz (adds a ~ after ext) which doesn't actually exist.

Which category does this issue belong to?

No response

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

No response

Which operating system are you running Bazel on?

macOS 13.4.1

What is the output of `bazel info release`?

release 6.3.1

If `bazel info release` returns `development version` or `(@non-git)`, tell us how you built Bazel.

No response

What's the output of `git remote get-url origin; git rev-parse master; git rev-parse HEAD` ?

No response

Is this a regression? If yes, please try to identify the Bazel commit where the bug was introduced.

No response

Have you found anything relevant by searching the web?

No

Any other information, logs, or outputs that you want to share?

No response

The text was updated successfully, but these errors were encountered:

fmeum · 2023-08-03T12:02:41Z

Can confirm that this is a bug. The two extensions are assigned the prefixes _main~my_ext~ and _main~my_ext~2~ now, which is bad since the former is a prefix of the latter.

I am working on a fix.

CC @Wyverald

fmeum · 2023-08-03T12:03:05Z

@bazel-io flag

iancha1992 · 2023-08-03T17:11:40Z

@bazel-io fork 6.4.0

fmeum · 2023-08-03T18:25:56Z

@iancha1992 This is a regression from Bazel 6.2.0, so unfortunately we may need a 6.3.2 release to cherry-pick this into.

iancha1992 · 2023-08-03T18:55:31Z

cc: @bazelbuild/triage

Fixes errors such as the following when a module provides two extensions that share a name: ``` ERROR: /my/workspace/library_path/BUILD:4:13: no such package '@_main~my_ext~2~xyz//': The repository '@_main~my_ext~2~xyz' could not be resolved: Repository '@_main~my_ext~2~xyz' is not defined and referenced by '//library_path:library_name' ERROR: Analysis of target '//my_path:my_target' failed; build aborted: ``` This was a consequence of the extension unique names followed by `~` being ``` _main~my_ext~2~ _main~my_ext~ ``` since 19a9710. Before, they were of the following form, which was prefix-free: ``` _main~my_ext2~ _main~my_ext~ ``` Fixes bazelbuild#19155 Closes bazelbuild#19156. PiperOrigin-RevId: 553567725 Change-Id: I98650663fea3bfee77752a06a99132e507d91aef

…19164) Fixes errors such as the following when a module provides two extensions that share a name: ``` ERROR: /my/workspace/library_path/BUILD:4:13: no such package '@_main~my_ext~2~xyz//': The repository '@_main~my_ext~2~xyz' could not be resolved: Repository '@_main~my_ext~2~xyz' is not defined and referenced by '//library_path:library_name' ERROR: Analysis of target '//my_path:my_target' failed; build aborted: ``` This was a consequence of the extension unique names followed by `~` being ``` _main~my_ext~2~ _main~my_ext~ ``` since 19a9710. Before, they were of the following form, which was prefix-free: ``` _main~my_ext2~ _main~my_ext~ ``` Fixes #19155 Closes #19156. PiperOrigin-RevId: 553567725 Change-Id: I98650663fea3bfee77752a06a99132e507d91aef Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>

…19167) Fixes errors such as the following when a module provides two extensions that share a name: ``` ERROR: /my/workspace/library_path/BUILD:4:13: no such package '@_main~my_ext~2~xyz//': The repository '@_main~my_ext~2~xyz' could not be resolved: Repository '@_main~my_ext~2~xyz' is not defined and referenced by '//library_path:library_name' ERROR: Analysis of target '//my_path:my_target' failed; build aborted: ``` This was a consequence of the extension unique names followed by `~` being ``` _main~my_ext~2~ _main~my_ext~ ``` since 19a9710. Before, they were of the following form, which was prefix-free: ``` _main~my_ext2~ _main~my_ext~ ``` Fixes #19155 Closes #19156. PiperOrigin-RevId: 553567725 Change-Id: I98650663fea3bfee77752a06a99132e507d91aef Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>

xiemotongye added type: bug untriaged labels Aug 3, 2023

xiemotongye assigned iancha1992, Pavank1992 and sgowroji Aug 3, 2023

Pavank1992 added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label Aug 3, 2023

Pavank1992 unassigned sgowroji, Pavank1992 and iancha1992 Aug 3, 2023

bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Aug 3, 2023

fmeum mentioned this issue Aug 3, 2023

Ensure that extension unique names followed by ~ are prefix-free #19156

Closed

bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Aug 3, 2023

bazel-io mentioned this issue Aug 3, 2023

[6.4.0] same module_extension name in different bzl files could not be resolved while using bzlmod in bazel 6.3.1 #19161

Closed

Wyverald added P1 I'll work on this now. (Assignee required) area-Bzlmod Bzlmod-specific PRs, issues, and feature requests and removed untriaged labels Aug 3, 2023

Wyverald assigned fmeum Aug 3, 2023

copybara-service bot closed this as completed in 896b358 Aug 3, 2023

iancha1992 mentioned this issue Aug 3, 2023

[6.4.0] Ensure that extension unique names followed by ~ are prefix-free #19164

Merged

bazel-io mentioned this issue Aug 3, 2023

[6.3.2] Ensure that extension unique names followed by ~ are prefix-free #19167

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

same `module_extension` name in different bzl files could not be resolved while using bzlmod in bazel 6.3.1 #19155

same `module_extension` name in different bzl files could not be resolved while using bzlmod in bazel 6.3.1 #19155

xiemotongye commented Aug 3, 2023 •

edited

Loading

fmeum commented Aug 3, 2023 •

edited

Loading

fmeum commented Aug 3, 2023

iancha1992 commented Aug 3, 2023

fmeum commented Aug 3, 2023

iancha1992 commented Aug 3, 2023

same module_extension name in different bzl files could not be resolved while using bzlmod in bazel 6.3.1 #19155

same module_extension name in different bzl files could not be resolved while using bzlmod in bazel 6.3.1 #19155

Comments

xiemotongye commented Aug 3, 2023 • edited Loading

Description of the bug:

Which category does this issue belong to?

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Which operating system are you running Bazel on?

What is the output of bazel info release?

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

Is this a regression? If yes, please try to identify the Bazel commit where the bug was introduced.

Have you found anything relevant by searching the web?

Any other information, logs, or outputs that you want to share?

fmeum commented Aug 3, 2023 • edited Loading

fmeum commented Aug 3, 2023

iancha1992 commented Aug 3, 2023

fmeum commented Aug 3, 2023

iancha1992 commented Aug 3, 2023

same `module_extension` name in different bzl files could not be resolved while using bzlmod in bazel 6.3.1 #19155

same `module_extension` name in different bzl files could not be resolved while using bzlmod in bazel 6.3.1 #19155

xiemotongye commented Aug 3, 2023 •

edited

Loading

What is the output of `bazel info release`?

If `bazel info release` returns `development version` or `(@non-git)`, tell us how you built Bazel.

What's the output of `git remote get-url origin; git rev-parse master; git rev-parse HEAD` ?

fmeum commented Aug 3, 2023 •

edited

Loading