Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incompatible_struct_has_no_methods #19465

Closed
comius opened this issue Sep 8, 2023 · 3 comments
Closed

incompatible_struct_has_no_methods #19465

comius opened this issue Sep 8, 2023 · 3 comments
Assignees
@comius
Labels
incompatible-change Incompatible/breaking change migration-ready Incompatible flag is ready for migration with Bazel rolling releases or Bazel@last_green

Comments

@comius
Copy link
Contributor

comius commented Sep 8, 2023

No description provided.

@comius comius added incompatible-change Incompatible/breaking change migration-ready Incompatible flag is ready for migration with Bazel rolling releases or Bazel@last_green labels Sep 8, 2023
@comius comius self-assigned this Sep 8, 2023
@c-mita
Copy link
Member

c-mita commented Mar 14, 2024

For any construct foo, the conversion is simple:

foo.to_json() -> json.encode(foo)
and
foo.to_proto() -> proto.encode_text(foo)

@c-mita
Copy link
Member

c-mita commented Mar 19, 2024 •
edited
Loading

The following should be merged before this is flipped:

@c-mita
Copy link
Member

c-mita commented Mar 20, 2024

The PRs being sent out for known issues was considered sufficient warning for flipping this.

aherrmann added a commit to aherrmann/rules_zig that referenced this issue Mar 22, 2024
@aherrmann
Use json.encode instead of struct method.
edbb216 
See bazelbuild/bazel#19465
@aherrmann aherrmann mentioned this issue Mar 22, 2024
Merged
@sgowroji sgowroji mentioned this issue Mar 28, 2024
Closed
copybara-service bot pushed a commit that referenced this issue Apr 8, 2024
@c-mita @copybara-github
Remove --incompatible_struct_has_no_methods and associated struct met…
c3dc389 
…hods.

Removes the disabled struct.to_json() and struct.to_proto() and the flag
that could re-enable them.

#19465

RELNOTES[inc]: Removed --incompatible_struct_has_no_methods

PiperOrigin-RevId: 622844911
Change-Id: Ie6a9b42a0ea6f45bfca40bd59a4ea6163214bebc
Kila2 pushed a commit to Kila2/bazel that referenced this issue May 13, 2024
@c-mita @Kila2
Remove --incompatible_struct_has_no_methods and associated struct met…
219065b 
…hods.

Removes the disabled struct.to_json() and struct.to_proto() and the flag
that could re-enable them.

bazelbuild#19465

RELNOTES[inc]: Removed --incompatible_struct_has_no_methods

PiperOrigin-RevId: 622844911
Change-Id: Ie6a9b42a0ea6f45bfca40bd59a4ea6163214bebc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@comius comius

Labels
incompatible-change Incompatible/breaking change migration-ready Incompatible flag is ready for migration with Bazel rolling releases or Bazel@last_green
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@comius @c-mita