-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
java_import should support add_opens and add_exports #19556
Labels
P2
We'll consider working on this in future. (Assignee optional)
team-Rules-Java
Issues for Java rules
type: feature request
Comments
hvadehra
added
P2
We'll consider working on this in future. (Assignee optional)
and removed
untriaged
labels
Oct 5, 2023
@iancha1992 Can we backport #20035 to 7.0? |
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this issue
Nov 17, 2023
This reduces the difference between `java_import` and other Java rules, like `java_library` and `java_binary`. * Propagate `add_exports` and `add_opens` through `java_import` * Add tests Fixes bazelbuild#19556. Closes bazelbuild#20035. PiperOrigin-RevId: 582617247 Change-Id: I513536acd4994de36190a5d79c2e92ac3f3ccc66
timothyg-stripe
added a commit
to timothyg-stripe/bazel
that referenced
this issue
Nov 18, 2023
This reduces the difference between `java_import` and other Java rules, like `java_library` and `java_binary`. * Propagate `add_exports` and `add_opens` through `java_import` * Add tests Fixes bazelbuild#19556. Closes bazelbuild#20035. PiperOrigin-RevId: 582617247 Change-Id: I513536acd4994de36190a5d79c2e92ac3f3ccc66
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
P2
We'll consider working on this in future. (Assignee optional)
team-Rules-Java
Issues for Java rules
type: feature request
Description of the feature request:
2217b13 adds support for
add_opens
andadd_exports
attributes tojava_library
,java_binary
, andjava_import
. Butjava_import
is left out.java_import
should support these attributes too.Which category does this issue belong to?
Java Rules
What underlying problem are you trying to solve with this feature?
We currently use
java_import
to import the release jars for google-java-format, which require the following flags in order to run without warnings:We could work around this issue by adding a
java_library
wrapper, but this is inconvenient.Which operating system are you running Bazel on?
macOS
What is the output of
bazel info release
?release 6.2.0
If
bazel info release
returnsdevelopment version
or(@non-git)
, tell us how you built Bazel.No response
What's the output of
git remote get-url origin; git rev-parse master; git rev-parse HEAD
?No response
Have you found anything relevant by searching the web?
No response
Any other information, logs, or outputs that you want to share?
No response
The text was updated successfully, but these errors were encountered: