Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.4.0] Wire up internal-inline-outputs requirement with RE API #23511

Closed
bazel-io opened this issue Sep 4, 2024 · 3 comments
Closed

[7.4.0] Wire up internal-inline-outputs requirement with RE API #23511

bazel-io opened this issue Sep 4, 2024 · 3 comments
Milestone
7.4.0 release blo...

Comments

@bazel-io
Copy link
Member

bazel-io commented Sep 4, 2024

Forked from #23428
@bazel-io bazel-io added this to the 7.4.0 release blockers milestone Sep 4, 2024
@bazel-io
Copy link
Member Author

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/remote/GrpcCacheClient.java
src/main/java/com/google/devtools/build/lib/remote/RemoteCache.java
src/main/java/com/google/devtools/build/lib/remote/common/RemoteCacheClient.java
src/main/java/com/google/devtools/build/lib/remote/http/HttpCacheClient.java
src/test/java/com/google/devtools/build/lib/remote/GrpcCacheClientTest.java
src/test/java/com/google/devtools/build/lib/remote/RemoteCacheTest.java
src/test/java/com/google/devtools/build/lib/remote/RemoteRepositoryRemoteExecutorTest.java
src/test/java/com/google/devtools/build/lib/remote/http/HttpCacheClientTest.java
src/test/java/com/google/devtools/build/lib/remote/util/InMemoryCacheClient.java
src/test/shell/bazel/remote/remote_execution_test.sh
src/tools/remote/src/main/java/com/google/devtools/build/remote/worker/ActionCacheServer.java

cc: @bazelbuild/triage

@iancha1992
Copy link
Member

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/remote/GrpcCacheClient.java src/main/java/com/google/devtools/build/lib/remote/RemoteCache.java src/main/java/com/google/devtools/build/lib/remote/common/RemoteCacheClient.java src/main/java/com/google/devtools/build/lib/remote/http/HttpCacheClient.java src/test/java/com/google/devtools/build/lib/remote/GrpcCacheClientTest.java src/test/java/com/google/devtools/build/lib/remote/RemoteCacheTest.java src/test/java/com/google/devtools/build/lib/remote/RemoteRepositoryRemoteExecutorTest.java src/test/java/com/google/devtools/build/lib/remote/http/HttpCacheClientTest.java src/test/java/com/google/devtools/build/lib/remote/util/InMemoryCacheClient.java src/test/shell/bazel/remote/remote_execution_test.sh src/tools/remote/src/main/java/com/google/devtools/build/remote/worker/ActionCacheServer.java

cc: @bazelbuild/triage

@tjgq @fmeum @lawchingman

@fmeum fmeum mentioned this issue Sep 23, 2024
Merged
@iancha1992
Copy link
Member

Cherry-picked in #23714

github-merge-queue bot pushed a commit that referenced this issue Sep 23, 2024
@fmeum
[7.4.0] Wire up internal-inline-outputs requirement with RE API (#2…
52542f2 
…3714)

In-memory outputs marked with the `internal-inline-outputs` execution
requirement are now added to the `inline_output_files` hint field of the
remote execution and remote cache API, potentially saving a round trip
on files that are unconditionally read by Bazel client after spawn
execution.

Support for output file inlining has been added to the remote worker
implementation.

Fixes #8421.

Closes #23428.

PiperOrigin-RevId: 673938116
Change-Id: Ieaea53502c43f9fc90b99f72dd4cdb4711239dd3 
(cherry picked from commit 56ad5d2)

Closes #23511
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.4.0 release blockers
Development

No branches or pull requests
2 participants
@bazel-io @iancha1992