Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing --remote_instance_name should invalidate cached digests #23780

Open
tpudlik opened this issue Sep 26, 2024 · 2 comments
Open

Changing --remote_instance_name should invalidate cached digests #23780

tpudlik opened this issue Sep 26, 2024 · 2 comments
Assignees
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Remote-Exec Issues and PRs for the Execution (Remote) team type: bug

Comments

@tpudlik
Copy link
Contributor

tpudlik commented Sep 26, 2024

Description of the bug:

In incremental builds, Bazel assumes any digest found to be valid in a previous execution will remain valid for a period of time. In particular, this is true even across invocations with --remote_instance_name set to different values. But if you're switching to a new remote instance, its contents will of course be different, so all cache digests ought to be invalidated. Otherwise, incremental builds with fail with spurious SPAWN(REMOTE_CACHE_EVICTED) errors.

The same may apply to some other flags that control which cache instance Bazel communicates with, like --remote_cache.

Which category does this issue belong to?

Remote Execution

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

No response

Which operating system are you running Bazel on?

No response

What is the output of bazel info release?

No response

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

No response

If this is a regression, please try to identify the Bazel commit where the bug was introduced with bazelisk --bisect.

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

For Googlers: see b/369413203 for an instance of this bug "poisoning" CI bots.

@github-actions github-actions bot added the team-Remote-Exec Issues and PRs for the Execution (Remote) team label Sep 26, 2024
@tpudlik
Copy link
Contributor Author

tpudlik commented Sep 26, 2024

@tjgq FYI

@jin jin added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed untriaged labels Oct 1, 2024
@coeuvre coeuvre added P2 We'll consider working on this in future. (Assignee optional) and removed P3 We're not considering working on this, but happy to review a PR. (No assignee) labels Oct 1, 2024
@layus
Copy link
Contributor

layus commented Oct 2, 2024

Chiming in to add --disk_cache to the list of flags to be monitored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Remote-Exec Issues and PRs for the Execution (Remote) team type: bug
Projects
None yet
Development

No branches or pull requests

7 participants