Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification to remote (and disk) caches should invalidate persistent action cache remote metadata #23841

Closed
layus opened this issue Oct 2, 2024 · 3 comments

Comments

@layus
Copy link
Contributor

layus commented Oct 2, 2024

Description of the bug:

When changing cache locations and/or cache options, the metadata stored in the persistent action cache becomes stale. Bazel starts erroring on missing remote blobs. Its easy to reproduce with remote execution and bwtb.

Just like when some flag changes invalidate the evaluation cache, I think changes to cache-related flags should invalidate the remote metadata in the persistent action cache.

This is a bit more tricky, because changes to these flags may or may not stem from a concrete change in the cache (like the cache secret key), but better safe than sorry. Invalidating that cache is not a huge loss, and cache changes are not supposed to happen frequently.

Then only way I know to discard that cache is bazel clean, which is more aggressive than needed because it also discards local data.

Which category does this issue belong to?

No response

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

No response

Which operating system are you running Bazel on?

Ubuntu

What is the output of bazel info release?

bazel 7.2

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

No response

If this is a regression, please try to identify the Bazel commit where the bug was introduced with bazelisk --bisect.

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@layus
Copy link
Contributor Author

layus commented Oct 2, 2024

See also #8248

@coeuvre
Copy link
Member

coeuvre commented Oct 2, 2024

Duplicate of #23780?

@layus
Copy link
Contributor Author

layus commented Oct 2, 2024

Yes, #23780 seems close enough.

@layus layus closed this as not planned Won't fix, can't repro, duplicate, stale Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants