Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store remote metadata in the on disk action cache #8248

Closed
buchgr opened this issue May 7, 2019 · 4 comments
Closed

Store remote metadata in the on disk action cache #8248

buchgr opened this issue May 7, 2019 · 4 comments
Assignees
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Remote-Exec Issues and PRs for the Execution (Remote) team type: feature request

Comments

@buchgr
Copy link
Contributor

buchgr commented May 7, 2019

This is part of #6862.

The persistent action cache stores the state of Bazel's output base. It does not know about remotely stored files. We need to extend it to do so.

$ bazel build :foo --experimental_remote_download_outputs=minimal
$ bazel shutdown
# This will be clean build, because the metadata from the previous build are
# not yet properly persisted to disk
$ bazel build :foo --experimental_remote_download_outputs=minimal
@buchgr buchgr self-assigned this May 7, 2019
@buchgr buchgr added team-Remote-Exec Issues and PRs for the Execution (Remote) team type: feature request labels May 7, 2019
@moroten
Copy link
Contributor

moroten commented Dec 13, 2019

This problem makes up to several minutes for me. Any updates on priority?

@buchgr buchgr removed their assignment Dec 15, 2019
@buchgr
Copy link
Contributor Author

buchgr commented Dec 15, 2019

No updates.

@moroten
Copy link
Contributor

moroten commented Dec 16, 2019

I saw the related #10233 which talks about refactoring findMissingBlobs. Is there more difficulties relating to --experimental_inmemory_jdeps_files and --experimental_inmemory_dotd_files that needs to be considered? Would the right way to solve this issue be to implement --disk_cache support in combination with remote execution or should there be another flag involved?

I do see this phenomenon also when the analysis cache is discarded due to changing configuration flags, even if the server is still alive.

@jin jin added the untriaged label Apr 16, 2020
@coeuvre coeuvre added P2 We'll consider working on this in future. (Assignee optional) and removed untriaged labels Dec 9, 2020
@coeuvre coeuvre self-assigned this Dec 9, 2020
@coeuvre
Copy link
Member

coeuvre commented Aug 4, 2021

This can be enabled by setting --experimental_action_cache_store_output_metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Remote-Exec Issues and PRs for the Execution (Remote) team type: feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants