Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.4.0] Disallow importing injected repos #23799

Closed
bazel-io opened this issue Sep 28, 2024 · 3 comments
Closed

[7.4.0] Disallow importing injected repos #23799

bazel-io opened this issue Sep 28, 2024 · 3 comments
Milestone
7.4.0 release blo...

Comments

@bazel-io
Copy link
Member

Forked from #23798
@bazel-io bazel-io added this to the 7.4.0 release blockers milestone Sep 28, 2024
@bazel-io
Copy link
Member Author

bazel-io commented Oct 8, 2024

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleThreadContext.java
src/test/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionResolutionTest.java
src/test/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleFileFunctionTest.java

cc: @bazelbuild/triage

@iancha1992
Copy link
Member

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleThreadContext.java src/test/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionResolutionTest.java src/test/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleFileFunctionTest.java

cc: @bazelbuild/triage

@fmeum @Wyverald @meteorcloudy

@fmeum
Copy link
Collaborator

fmeum commented Oct 10, 2024

Included in #23938, I just need to fix CI.

@fmeum fmeum mentioned this issue Oct 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 10, 2024
@fmeum @Wyverald
[7.4.0] Add override_repo and inject_repo (#23938)
067ce4d 
Work towards #19301
Fixes #23580

RELNOTES: `override_repo` and `inject_repo` can be used to override and
inject repos in module extensions.

Closes #23534.

PiperOrigin-RevId: 678139661
Change-Id: Iea7caca949c00e701f056c1037e273fee9740e93

(cherry picked from commit
46341b1)

Fixes #23724
Fixes #23799

Also includes:
* Disallow importing injected repos
(8472c9d)

---------

Co-authored-by: Xùdōng Yáng <wyverald@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.4.0 release blockers
Development

No branches or pull requests
4 participants
@Wyverald @fmeum @bazel-io @iancha1992