Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: add a beginner tutorial for Go #23958

Closed
wants to merge 5 commits into from

Conversation

jayconrod
Copy link
Contributor

This augments the beginner tutorials for C++, Java, Android, and iOS.

I kept the structure similar to the C++ tutorial but included some brief information on MODULE.bazel, since that's required for rules_go.

This augments the beginner tutorials for C++, Java, Android, and iOS.

I kept the structure similar to the C++ tutorial but included
some brief information on MODULE.bazel, since that's required for
rules_go.
@jayconrod
Copy link
Contributor Author

Examples PR: bazelbuild/examples#519

@github-actions github-actions bot added team-Documentation Documentation improvements that cannot be directly linked to other team labels awaiting-review PR is awaiting review from an assigned reviewer labels Oct 11, 2024
@iancha1992 iancha1992 added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Oct 11, 2024
@jayconrod
Copy link
Contributor Author

A gentle ping for review. I sent this just before Bazelcon, so I apologize for the awkward timing.

Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/cc @fmeum in case you also want to take a look.

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Oct 24, 2024
site/en/start/go.md Outdated Show resolved Hide resolved
- To get started building other applications with Bazel, see the tutorials for [C++](/start/cpp), [Java](/start/java), [Android](/start/android-app), and [iOS](/start/ios-app).
- You can also check the list of [recommended rules](/rules) for other languages.
- For more information on Go, see the [rules_go](https://github.com/bazelbuild/rules_go) module, especially the [Core Go rules](https://github.com/bazelbuild/rules_go/blob/master/docs/go/core/rules.md) docuemntation.
- To learn more about working with modules outside your project, see [external dependencies](/docs/external).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could make sense to say Bazel modules here as Go modules would be fetched with Gazelle.

Could you also mention external deps and reference the rules_go bzlmod.md guide for that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, made both changes.

@jayconrod
Copy link
Contributor Author

Thanks for reviewing! bazelbuild/examples#519 has the example code for this, so let me know if you have feedback for that one, too.


Estimated completion time: 30 minutes

## What you'll learn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there actually missing content for ## What you'll learn?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant to take that heading out, now done. I initially followed some of the structure from the Java tutorial, but then it seemed better to just write the things you'll learn in the first paragraph.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Np!

@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Oct 28, 2024
@meteorcloudy
Copy link
Member

I had to make some small tweaks while importing this PR based on https://developers.google.com/style, feel free to send follow up PRs if you think some of the modifications don't make sense.

@jayconrod
Copy link
Contributor Author

Looks good! Thanks again for reviewing and publishing.

@meteorcloudy
Copy link
Member

Thanks for the nice documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Documentation Documentation improvements that cannot be directly linked to other team labels team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants