-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
site: add a beginner tutorial for Go #23958
Conversation
This augments the beginner tutorials for C++, Java, Android, and iOS. I kept the structure similar to the C++ tutorial but included some brief information on MODULE.bazel, since that's required for rules_go.
Examples PR: bazelbuild/examples#519 |
A gentle ping for review. I sent this just before Bazelcon, so I apologize for the awkward timing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/cc @fmeum in case you also want to take a look.
site/en/start/go.md
Outdated
- To get started building other applications with Bazel, see the tutorials for [C++](/start/cpp), [Java](/start/java), [Android](/start/android-app), and [iOS](/start/ios-app). | ||
- You can also check the list of [recommended rules](/rules) for other languages. | ||
- For more information on Go, see the [rules_go](https://github.com/bazelbuild/rules_go) module, especially the [Core Go rules](https://github.com/bazelbuild/rules_go/blob/master/docs/go/core/rules.md) docuemntation. | ||
- To learn more about working with modules outside your project, see [external dependencies](/docs/external). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could make sense to say Bazel modules
here as Go modules would be fetched with Gazelle.
Could you also mention external deps and reference the rules_go bzlmod.md
guide for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, made both changes.
Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Thanks for reviewing! bazelbuild/examples#519 has the example code for this, so let me know if you have feedback for that one, too. |
site/en/start/go.md
Outdated
|
||
Estimated completion time: 30 minutes | ||
|
||
## What you'll learn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there actually missing content for ## What you'll learn
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I meant to take that heading out, now done. I initially followed some of the structure from the Java tutorial, but then it seemed better to just write the things you'll learn in the first paragraph.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Np!
I had to make some small tweaks while importing this PR based on https://developers.google.com/style, feel free to send follow up PRs if you think some of the modifications don't make sense. |
Looks good! Thanks again for reviewing and publishing. |
Thanks for the nice documentation! |
This augments the beginner tutorials for C++, Java, Android, and iOS.
I kept the structure similar to the C++ tutorial but included some brief information on MODULE.bazel, since that's required for rules_go.