Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.6.0 #3286

Closed
hlopko opened this issue Jun 28, 2017 · 39 comments
Closed

Release 0.6.0 #3286

hlopko opened this issue Jun 28, 2017 · 39 comments
Assignees
Labels
P1 I'll work on this now. (Assignee required) release type: process

Comments

@hlopko
Copy link
Member

hlopko commented Jun 28, 2017

Is it time for our next major release?

@hlopko hlopko added Release blocker P1 I'll work on this now. (Assignee required) type: process labels Jun 28, 2017
@hlopko hlopko mentioned this issue Jun 28, 2017
@hlopko
Copy link
Member Author

hlopko commented Jun 29, 2017

First release blocker: #3293

@buchgr
Copy link
Contributor

buchgr commented Jul 13, 2017

0.5.3 first :) #3375

@damienmg damienmg assigned vladmos and unassigned buchgr Jul 25, 2017
@damienmg
Copy link
Contributor

@vladmos since Jakob is doing 0.5.3, you are the next in line, and since you wanted to have some breaking change in 0.6.0 I guess being the RM will help :)

@helenalt is going to help scope 0.6

@abergmeier-dsfishlabs
Copy link
Contributor

you wanted to have some breaking change in 0.6.0

Well there were breaking changes in 0.5.3 already. IMO breaking anything before 1.0 is fair game (although I do grind my teeth ever time 😄 ).

@ittaiz
Copy link
Member

ittaiz commented Sep 8, 2017

Hi,
Any idea when this release will roll out?

@buchgr
Copy link
Contributor

buchgr commented Sep 8, 2017

@ittaiz I believe next week since @vladmos is on vacation this week.

@vladmos
Copy link
Member

vladmos commented Sep 13, 2017

The first release candidate has been created: https://github.com/bazelbuild/bazel/tree/release-0.6.0 (baseline 87cc92e).

@petemounce
Copy link
Contributor

@petemounce
Copy link
Contributor

One of the release note bullets is just fixes #3552?

@vladmos
Copy link
Member

vladmos commented Sep 13, 2017

Yes, it came from 65e0f78. I'll remove this item manually if there's another RC.

@abergmeier-dsfishlabs
Copy link
Contributor

  • Python is now required to build bazel

So Python2 and/or Python3?

@vladmos
Copy link
Member

vladmos commented Sep 18, 2017

Created an RC2 with cherry-picked a615d28.

@petemounce
Copy link
Contributor

@iirina
Copy link
Contributor

iirina commented Sep 19, 2017

Sorry for crashing the party so late, but do you have room for another cherry pick? 655a529 It's an incompatible change and I would like to get it into this release.

@dslomov
Copy link
Contributor

dslomov commented Sep 19, 2017

We should try to not cherry-pick features into release candidates, and 655a529 is a feature.
Moreover, since it is an incompatible change, we should ideally be protecting it with a flag.

@davido
Copy link
Contributor

davido commented Sep 19, 2017

What about this issue fixed by this non-intrusive change, protected by two innocent experimental flags, that are disabled by default?

@damienmg
Copy link
Contributor

damienmg commented Sep 19, 2017 via email

@davido
Copy link
Contributor

davido commented Sep 19, 2017

@damienmg Thanks for explanation. Let's hope that a fix for #3042 will make it in upcoming 0.7 release then.

@meteorcloudy
Copy link
Member

meteorcloudy commented Sep 20, 2017

Can we cherrypick 213a52a? It fixes #3717

@damienmg
Copy link
Contributor

Not a regression so no.

@meteorcloudy
Copy link
Member

Cool, let's wait for the next release.

@grandseiken
Copy link

grandseiken commented Sep 21, 2017

On 0.6 our custom crosstool needed updated to replace copts with user_compile_flags, but I don't see a release note about this currently.

@hlopko
Copy link
Member Author

hlopko commented Sep 21, 2017

@grandseiken correct, there is no release note, but neither was about copts availability. I tried to keep my changes under the radar so people will only start using it when I'm fully done. I didn't know that improbable.io has a custom crosstool with 'no_legacy_features'. I can ping you with next changes (I only expect 3 more coming).

@damienmg
Copy link
Contributor

7b091c1 to cherrypick

@grandseiken
Copy link

@mhlopko no worries, that stuff is all undocumented anyway. If you have the chance to ping me that'd be great but no biggie.

@vladmos
Copy link
Member

vladmos commented Sep 22, 2017

Created RC3
Baseline: 87cc92e
Cherry-pick: a615d28
Cherry-pick: 7b091c1

@petemounce
Copy link
Contributor

@vladmos
Copy link
Member

vladmos commented Sep 25, 2017

I had to cherry-pick another commit because otherwise there was a regression in tracebacks.

Created RC4
Baseline: 87cc92e
Cherry-pick: a615d28
Cherry-pick: 7b091c1
Cherry-pick: 95b0467

bazel-io pushed a commit that referenced this issue Sep 26, 2017
as it was not part of a valid junit xml schema.

To cherry-pick for #3286.

RELNOTES: None.
PiperOrigin-RevId: 170022796
vladmos pushed a commit that referenced this issue Sep 26, 2017
as it was not part of a valid junit xml schema.

To cherry-pick for #3286.

RELNOTES: None.
PiperOrigin-RevId: 170022796
@vladmos
Copy link
Member

vladmos commented Sep 26, 2017

Created RC5
Baseline: 87cc92e
Cherry-pick: a615d28
Cherry-pick: 7b091c1
Cherry-pick: 95b0467
Cherry-pick: cc9c2f0

@petemounce
Copy link
Contributor

https://chocolatey.org/packages/bazel/0.6.0-rc5 is available now (so is 4, belatedly). It's lovely in Kefalonia right now, highly recommend. ;)

@ola-rozenfeld
Copy link
Contributor

Hi!
We really need to have 7744b86 and 6f32d5a in the release. First is a bugfix for BES, and second enables logging on our end, which is crucial for us.
Thank you!

@dslomov
Copy link
Contributor

dslomov commented Sep 27, 2017

Next release is 0.7, cut on Oct 2nd. We can also consider a patch release, 0.6.1, with these cherrypicks; but none of commits 7744b86 and 6f32d5a fix regressions from 0.5.4 afaics.

@ola-rozenfeld
Copy link
Contributor

You mean 0.7 will be out on Oct 7? If so, we can wait for that. 7744b86 actually does fix a previous regression, introduced in 562fcf9. willsc@ has asked me to ask you to patch it in, please, unless it's too much trouble. They are using my patched version instead of the release for this reason.

@dslomov
Copy link
Contributor

dslomov commented Sep 27, 2017

I suggest that you wait for 0.7. RC will be available on Oct 2, and then you can use that.

@ola-rozenfeld
Copy link
Contributor

OK, we will do that, thank you! Btw, when will the release 0.6.0 come out?

@damienmg
Copy link
Contributor

damienmg commented Sep 27, 2017 via email

@vladmos
Copy link
Member

vladmos commented Sep 29, 2017

0.6.0 is released. @petemounce please upload it to Chocolatey.

@petemounce
Copy link
Contributor

https://chocolatey.org/packages/bazel/0.6.0 is available now.

@vladmos
Copy link
Member

vladmos commented Sep 29, 2017

Thanks!
It's also available on Homebrew.

@vladmos vladmos closed this as completed Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 I'll work on this now. (Assignee required) release type: process
Projects
None yet
Development

No branches or pull requests