Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote/performance: add gzip compression to HTTP remote cache #4575

Closed
buchgr opened this issue Feb 2, 2018 · 7 comments
Closed

remote/performance: add gzip compression to HTTP remote cache #4575

buchgr opened this issue Feb 2, 2018 · 7 comments
Labels
P2 We'll consider working on this in future. (Assignee optional) stale Issues or PRs that are stale (no activity for 30 days) team-Remote-Exec Issues and PRs for the Execution (Remote) team type: feature request

Comments

@buchgr
Copy link
Contributor

buchgr commented Feb 2, 2018

The Apache client supported gzip, but the new Netty client doesn't.

cc: @jgavris

@buchgr buchgr added the P1 I'll work on this now. (Assignee required) label Feb 2, 2018
@buchgr buchgr self-assigned this Feb 2, 2018
@jgavris
Copy link
Contributor

jgavris commented Feb 3, 2018

Let's also add Content-Type: application/octet-stream. I noticed the newer objects in my GCS bucket do not have this set either.

https://cloud.google.com/storage/docs/transcoding

@buchgr buchgr added remote caching and removed P1 I'll work on this now. (Assignee required) labels Mar 7, 2018
@buchgr buchgr changed the title add gzip compression to HTTP remote cache remote/performance: add gzip compression to HTTP remote cache Mar 14, 2018
@buchgr buchgr removed their assignment Mar 14, 2018
@buchgr buchgr added team-Remote-Exec Issues and PRs for the Execution (Remote) team P2 We'll consider working on this in future. (Assignee optional) and removed category: http caching labels Feb 5, 2019
@excitoon
Copy link
Contributor

I'd like to make little patches to implement this as it blocks me now.

excitoon added a commit to excitoon-favorites/bazel that referenced this issue Jun 20, 2019
@excitoon
Copy link
Contributor

It seems like it is pretty easy :)
@buchgr

@jgavris
Copy link
Contributor

jgavris commented Jun 20, 2019

@excitoon That might help for some cache backends, but for people on say, Google Cloud Storage as their cache backend, it does not do compressive transcoding (this would be very expensive with respect to CPU time). What Jakob and I were discussing offline was a scheme to store compressed blobs in GCS, and then detect and decompress them in the bazel client.

@excitoon
Copy link
Contributor

Yep, I know about buchgr/bazel-remote#12 , this is just a client-side thing. Anyway, it is at least a progress on this task!

excitoon added a commit to excitoon-favorites/bazel that referenced this issue Jun 25, 2019
excitoon added a commit to excitoon-favorites/bazel that referenced this issue Jun 25, 2019
excitoon added a commit to excitoon-favorites/bazel that referenced this issue Aug 20, 2019
excitoon added a commit to excitoon-favorites/bazel that referenced this issue Aug 20, 2019
@github-actions
Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 2.5 years. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Mar 16, 2023
@github-actions
Copy link

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please reach out to the triage team (@bazelbuild/triage). Thanks!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider working on this in future. (Assignee optional) stale Issues or PRs that are stale (no activity for 30 days) team-Remote-Exec Issues and PRs for the Execution (Remote) team type: feature request
Projects
None yet
Development

No branches or pull requests

4 participants