Release - May 2018 - Target RC date: 2018-05-04 - name: 0.14.0 #5056
Comments
|
@lfpino lmk if you are not available on these dates |
dslomov
changed the title
|
Thanks! Fixed. |
|
@dslomov, which dates exactly? I will be on vacation from Apr 27 until May 2 (inclusive), so from the issue title I won't be available. |
dslomov
changed the title
|
@lfpino Is there an approximate timeline for this release? Just wondering whether this will be pushed back to late May due to the delay in the 0.12/13 releases. |
|
Hello Robin, sorry for the delay. I'm working on creating a new Release candidate (we should have one today or on Monday). On the other hand, the release itself should happen late May. Hope it helps. |
|
I've created 0.14.0rc1 with baseline 5c3f5c9 and cherrypicked f96f037. The tests are running in https://buildkite.com/bazel/release/builds/40. |
|
The rules_scala failures (https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/233#cb39f107-6399-474f-92f3-e2a0fae08630) are tracked in bazelbuild/rules_scala#498 |
|
The Windows related failures are tracked in #5125. The failures in rules_python seem to be unrelated to Bazel since the test is failing with 0.12 and 0.13 too, I've reported them there: bazelbuild/rules_python#98 |
|
If we create another rc, can be please also cherry-pick ff8162d to keep FreeBSD a known platform? Thanks. |
|
Klaus, we don't need to. The shell toolchain is not yet in use. |
We still need the cherry-pick (or I have to locally patch it in the port); even if the shell toolchain is not yet used, |
|
In that case, would you accept waiting for a patch that removes the |
|
@aehlig : Before I start working on such a patch, could you please try if you can bootstrap on FreeBSD if you remove the |
|
could you please try if you can bootstrap on FreeBSD if you remove the `exec_compatible_with` altogether?
@laszlocsomor I can confirm that using the following patch instead of ff8162d also allows to bootstrap a working bazel on FreeBSD
```
--- tools/sh/sh_configure.bzl.orig 1980-01-01 00:00:00.000000000 +0000
+++ tools/sh/sh_configure.bzl 2018-05-16 09:37:28.256787000 +0000
@@ -49,16 +49,6 @@
if sh_path and _is_windows(repository_ctx):
sh_path = sh_path.replace("\\", "/")
- os_label = None
- if _is_windows(repository_ctx):
- os_label = "@bazel_tools//platforms:windows"
- elif repository_ctx.os.name.startswith("linux"):
- os_label = "@bazel_tools//platforms:linux"
- elif repository_ctx.os.name.startswith("mac"):
- os_label = "@bazel_tools//platforms:osx"
- else:
- fail("Unknown OS")
-
repository_ctx.file("BUILD", """
load("@bazel_tools//tools/sh:sh_toolchain.bzl", "sh_toolchain")
@@ -70,14 +60,10 @@
toolchain(
name = "local_sh_toolchain",
- exec_compatible_with = [
- "@bazel_tools//platforms:x86_64",
- "{os_label}",
- ],
toolchain = ":local_sh",
toolchain_type = "@bazel_tools//tools/sh:toolchain_type",
)
-""".format(sh_path = sh_path, os_label = os_label))
+""".format(sh_path = sh_path))
sh_config = repository_rule(
environ = [
```
…--
Klaus Aehlig
Google Germany GmbH, Erika-Mann-Str. 33, 80636 Muenchen
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschaeftsfuehrer: Paul Terence Manicle, Halimah DeLaine Prado
|
|
@aehlig : Thank you! Would you mind creating a PR for this patch and requesting to cherrypick that? |
|
@aehlig : Thank you! Would you mind creating a PR for this patch and requesting to cherrypick that?
That, as a change against bazel head, would be https://bazel-review.googlesource.com/c/bazel/+/56270
But note that this change is on top of ff8162d so cannot be cleanly cherry-picked without that change as an earlier cherry-pick. Or did you mean a patch against the release branch?
…--
Klaus Aehlig
Google Germany GmbH, Erika-Mann-Str. 33, 80636 Muenchen
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschaeftsfuehrer: Paul Terence Manicle, Halimah DeLaine Prado
|
Since that restriction is not necessary at the moment, we can as well not compute it in the first place. Potentially to be cherry-picked for 0.14.0, see bazelbuild#5056. Change-Id: Ic2d4ec1b037ce464e85e243b69bedd483bc515ac
|
No, I meant a standalone patch based directly on master, and cherry-picking that into the release branch. |
|
Ah, I missed the whole point. Yes, we need ff8162d otherwise https://bazel-review.googlesource.com/c/bazel/+/56270 cannot be cherrypicked cleanly. |
|
Link to pull request: #5156 |
|
Catching up - published 0.14.0-rc1 through rc4. |
|
New candidate created, details in https://releases.bazel.build/0.14.0/rc5/index.html Tests running in: https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/258 |
|
All looks green. We should be able to release release-0.14.0rc5 on Wednesday. |
|
I didn't manage to get to this today. The release will happen on Friday. Sorry for the delay. |
|
Pushed release: @petemounce : Could you please update Chocolatey? Thanks! |
|
Thank you @ilovezfs ! |
|
You're welcome. 0.14.0 shipped in Homebrew. |
|
Given that 0.14 is affected by #5336 and it's a pretty serious issue, essentially making Bazel potentially unusable on machines where Docker isn't in a good shape (and running |
|
+1 to patch release |
|
I'll create a patch release tomorrow. |
|
Hmm does #5308 warrant a patch release? |
|
@dslomov, it's not resolved yet because you didn't import the patch yet. I just sent you the import. |
|
I replied on the bug - I think we should merge the currently proposed fix, and cherrypick it. |
|
@alexeagle from Angular is reporting memory regressions with 0.14.1: https://groups.google.com/d/msg/bazel-discuss/SOHd4FWX-6Q/rX7-3uQ5BAAJ We should investigate and potentially roll out a 0.14.2 patch release. |
|
@dslomov can you please take a look since you handled 0.14.1? |
No description provided.
The text was updated successfully, but these errors were encountered: