Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows: support sandboxing [blocking #5640] #5136

Closed
laszlocsomor opened this issue May 2, 2018 · 13 comments
Closed

windows: support sandboxing [blocking #5640] #5136

laszlocsomor opened this issue May 2, 2018 · 13 comments
Labels
area-Windows Windows-specific issues and feature requests category: sandboxing P3 We're not considering working on this, but happy to review a PR. (No assignee) platform: windows stale Issues or PRs that are stale (no activity for 30 days) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: feature request

Comments

@laszlocsomor
Copy link
Contributor

Description of the problem / feature request:

This is an umbrella bug for the feature request of supporting sandboxing on Windows.

What operating system are you running Bazel on?

Windows 10

What's the output of bazel info release?

release 0.13.0

Have you found anything relevant by searching the web?

Microsoft recently opensourced Detours, which could be useful: https://github.com/Microsoft/Detours
@j3parker
Copy link
Contributor

I'm sure you're aware, but Windows has something called the Host Compute Service which is used to implement containers for things like Docker.

This blog post has the high level picture and they link to wrappers+sample code for C# and Go (which looks more complete and is what Docker actually uses.)

Maybe something from there would be useful?

@laszlocsomor
Copy link
Contributor Author

I wasn't aware, thanks for the info! Could be useful indeed. Though supporting the Docker-based sandbox strategy on Windows may be more convenient than implementing native sandboxing.

@j3parker
Copy link
Contributor

Cool! Makes sense.

@laszlocsomor laszlocsomor mentioned this issue Nov 9, 2018
Closed
@ilya-klyuchnikov
Copy link

FYI: https://github.com/Microsoft/BuildXL has an implementation of Windows Sandboxing

@laszlocsomor
Copy link
Contributor Author

@ilya-klyuchnikov -- Thanks for the heads-up! Very interesting, I'll take a look and try to build it.

@jin jin added area-Windows Windows-specific issues and feature requests untriaged labels Feb 19, 2019
@jin
Copy link
Member

jin commented Feb 19, 2019

@laszlocsomor could you please add a priority to this issue?

@laszlocsomor laszlocsomor added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed untriaged labels Feb 20, 2019
@laszlocsomor
Copy link
Contributor Author

Setting priority to p3 -- I don't expect much focus on this before Bazel 1.0 (though this is not ruled out either).

cocreature added a commit to digital-asset/daml that referenced this issue Apr 24, 2019
@cocreature
Fix concurrent DAML compilations on Windows
34371af 
Since Windows builds aren’t sandboxed properly (see
bazelbuild/bazel#5136), concurrent
compilations interact with the same tmp_db directory which leads to
flaky build failures.
@cocreature cocreature mentioned this issue Apr 24, 2019
Merged
5 tasks
cocreature added a commit to digital-asset/daml that referenced this issue Apr 24, 2019
@cocreature
Fix concurrent DAML compilations on Windows
05d8e9e 
Since Windows builds aren’t sandboxed properly (see
bazelbuild/bazel#5136), concurrent
compilations interact with the same tmp_db directory which leads to
flaky build failures.
cocreature added a commit to digital-asset/daml that referenced this issue Apr 24, 2019
@cocreature
Fix concurrent DAML compilations on Windows
b3e7ac0 
Since Windows builds aren’t sandboxed properly (see
bazelbuild/bazel#5136), concurrent
compilations interact with the same tmp_db directory which leads to
flaky build failures.
garyverhaegen-da pushed a commit to digital-asset/daml that referenced this issue Apr 24, 2019
@cocreature @garyverhaegen-da
Fix concurrent DAML compilations on Windows
2cb6a67 
Since Windows builds aren’t sandboxed properly (see
bazelbuild/bazel#5136), concurrent
compilations interact with the same tmp_db directory which leads to
flaky build failures.
garyverhaegen-da pushed a commit to digital-asset/daml that referenced this issue Apr 24, 2019
@cocreature @garyverhaegen-da
Fix concurrent DAML compilations on Windows
291296d 
Since Windows builds aren’t sandboxed properly (see
bazelbuild/bazel#5136), concurrent
compilations interact with the same tmp_db directory which leads to
flaky build failures.
mergify bot pushed a commit to digital-asset/daml that referenced this issue Apr 24, 2019
@cocreature @mergify
Fix concurrent DAML compilations on Windows (#679)
16d82f6 
Since Windows builds aren’t sandboxed properly (see
bazelbuild/bazel#5136), concurrent
compilations interact with the same tmp_db directory which leads to
flaky build failures.
@laszlocsomor
Copy link
Contributor Author

@rongjiecomputer is working on this feature \o/

@laszlocsomor laszlocsomor changed the title windows: support sandboxing windows: support sandboxing [blocking #5640] Jul 8, 2019
@konste
Copy link

konste commented Dec 5, 2019

I wonder if you looked at FUSE implementations for Windows, such as https://dokan-dev.github.io/ or http://www.secfs.net/winfsp/ ? As Bazel already makes use of sandboxfs for Linux and Mac it may be beneficial to utilize as similar tech as possible on Windows.

@aherrmann
Copy link
Contributor

@laszlocsomor @rongjiecomputer What's the status of this? Is the current progress documented somewhere?

@laszlocsomor
Copy link
Contributor Author

@aherrmann : @rongjiecomputer implemented experimental sandbox support as part of Google Summer of Code 2019 (GSoC).

All about the project is in a public Google doc: https://docs.google.com/document/d/1dbF5cGYJouGF5zd0GDE-rbUvkKvH36DnNdtEvE4yV6w/edit

The Bazel team does not maintain this feature. We currently have no plans to work on it either.

@philwo philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 15, 2020
@laszlocsomor laszlocsomor mentioned this issue Aug 21, 2020
Closed
@sloretz sloretz mentioned this issue Sep 29, 2021
Closed
@sluongng sluongng mentioned this issue May 9, 2022
Closed
@haoyunfeix haoyunfeix mentioned this issue Oct 8, 2022
Closed
@github-actions
Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 2.5 years. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Mar 16, 2023
@github-actions
Copy link

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please reach out to the triage team (@bazelbuild/triage). Thanks!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 31, 2023
@willjschmitt willjschmitt mentioned this issue Aug 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Windows Windows-specific issues and feature requests category: sandboxing P3 We're not considering working on this, but happy to review a PR. (No assignee) platform: windows stale Issues or PRs that are stale (no activity for 30 days) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@ilya-klyuchnikov @jin @philwo @j3parker @aherrmann @konste @laszlocsomor