[FR] .bazelignore should support wildcard prefix #7093

or-shachar · 2019-01-11T10:46:40Z

Description of the feature request:

Currently .bazelignore supports only full relative path prefix without any wildcards

I have many node_modules subfolders in my repo that I want to ignore.
With .gitignore I'd just need to put: node_modules and it will be ignored by git.
With .bazelignore I need to specify each folder by it's full relative path from workspace root.

I suggest to adjust behavior to the way .gitignore and save our users the trouble of collecting all folders.

What operating system are you running Bazel on?

We tested it on linux with bazel 0.20.0 and 0.21.0

The text was updated successfully, but these errors were encountered:

ittaiz · 2019-01-29T14:43:57Z

@iirina @dslomov when can we expect this to be triaged?

jupp0r · 2020-01-17T19:10:53Z

Is somebody working on this issue? If not, I'd like to start working on a patch.

gregmagolan · 2020-02-13T17:40:49Z

+1 for the Angular repo. .bazelrc could be a few lines with wildcards instead of

node_modules
dist
aio/content
aio/node_modules
aio/tools/examples/shared/node_modules
integration/bazel/node_modules
integration/bazel/.yarn_local_cache
integration/bazel-schematics/node_modules
integration/bazel-schematics/.yarn_local_cache
integration/bazel-schematics/demo
integration/cli-hello-world-ivy-compat/node_modules
integration/cli-hello-world-ivy-compat/node_modules
integration/cli-hello-world-ivy-i18n/node_modules
integration/cli-hello-world-ivy-minimal/node_modules
integration/cli-hello-world-lazy/node_modules
integration/cli-hello-world-lazy-rollup/node_modules
integration/dynamic-compiler/node_modules
integration/hello_world__closure/node_modules
integration/hello_world__systemjs_umd/node_modules
integration/i18n/node_modules
integration/injectable-def/node_modules
integration/ivy-i18n/node_modules
integration/language_service_plugin/node_modules
integration/ng_elements/node_modules
integration/ng_update/node_modules
integration/ng_update_migrations/node_modules
integration/ngcc/node_modules
integration/platform-server/node_modules
integration/service-worker-schema/node_modules
integration/side-effects/node_modules
integration/terser/node_modules
integration/typings_test_ts36/node_modules
integration/cli-hello-world/.yarn_local_cache
integration/cli-hello-world-ivy-compat/.yarn_local_cache
integration/cli-hello-world-ivy-i18n/.yarn_local_cache
integration/cli-hello-world-ivy-minimal/.yarn_local_cache
integration/cli-hello-world-lazy/.yarn_local_cache
integration/cli-hello-world-lazy-rollup/.yarn_local_cache
integration/dynamic-compiler/.yarn_local_cache
integration/hello_world__closure/.yarn_local_cache
integration/hello_world__systemjs_umd/.yarn_local_cache
integration/i18n/.yarn_local_cache
integration/injectable-def/.yarn_local_cache
integration/ivy-i18n/.yarn_local_cache
integration/language_service_plugin/.yarn_local_cache
integration/ng_elements/.yarn_local_cache
integration/ng_update/.yarn_local_cache
integration/ng_update_migrations/.yarn_local_cache
integration/ngcc/.yarn_local_cache
integration/platform-server/.yarn_local_cache
integration/service-worker-schema/.yarn_local_cache
integration/side-effects/.yarn_local_cache
integration/terser/.yarn_local_cache
integration/typings_test_ts36/.yarn_local_cache
packages/bazel/node_modules

cgruber · 2020-02-28T23:06:30Z

+1 for all the rules_* repos, which typically have a variety of sub-repos to handle testing the rules.

@tclem

@tclem ran into an issue where he had built `semantic-source` from the `semantic-source` directory; `cabal` placed a `dist-newstyle` directory there, which was fouling up Bazel due to the fact that `cabal` generates binary files called `BUILD`, and Bazel tries to interpret these files as package configurations. Not good! We can't use a glob here because .bazelignore files don't support globbing (bazelbuild/bazel#7093), so it suffices to ignore all the projects' `dist-newstyle` directories so that no one runs into this again.

@tclem

@tclem ran into an issue where he had built `semantic-source` from the `semantic-source` directory; `cabal` placed a `dist-newstyle` directory there, which was fouling up Bazel due to the fact that `cabal` generates binary files called `BUILD`, and Bazel tries to interpret these files as package configurations. Not good! We can't use a glob here because .bazelignore files don't support globbing (bazelbuild/bazel#7093), so it suffices to ignore all the projects' `dist-newstyle` directories so that no one runs into this again.

David-Lam · 2021-07-27T22:17:55Z

Hi everyone! I have create a PR #13756 that add wildcard to .bazelignore. Feel free to review it. Thanks! @cgruber @ittaiz

nkoroste · 2021-11-18T20:17:33Z

also related #13807

guw · 2022-01-11T06:47:40Z

Is this a dup of #8106?

Bazel removed `managed_directories` feature on Bazel@HEAD, see: [1]. Design document is here: [2]. Also extend the .bazelignore and add explicitly the path to the node_modules directories. Note, that Bazel currently doesn't support the same semantic as .gitignore. For more details see this issue: [3] and this issue specific to rules_nodejs: [4]. [1] bazelbuild/bazel#15463 [2] https://docs.google.com/document/d/1u9V5RUc7i6Urh8gGfnSurxpWA7JMRtwCi1Pr5BHeE44/edit [3] bazelbuild/bazel#7093 [4] bazelbuild/bazel#8106 Release-Notes: skip Change-Id: I5dc582e05e4116064fc06d438d4b8a8b57b6bb8d

Toxaris · 2023-01-31T22:52:19Z

Experience report:

Like others, we have a monorepo where developers run bazel build //... but we also install NodeJS packages into node_modules folders in the source tree (to make the IDE happy). We would prefer to put **/node_modules into the .bazelignore, but since that is not supported, we have a script that generates the .bazelignore from the repo structure, and a check in our CI that the .bazelignore has been generated by the script.

Even with these precautions, we run into issues after the repo structure has changed upstream and a developer does git checkout or git pull on their machine. Developers will get the new .bazelignore but still have the old node_modules folders in their source tree. Since the node_module folders contain symlinks to internal dependencies, bazel will expand the dependency graph into a tree and find an exponential number of copies of our internal packages. It will either crash because of memory issues, or try to make sense of these weird packages and run into visibility issues.

I acknowledge that the root cause here is really that we put non-source files into the source tree, but we are not aware of a practical way to avoid that (short of building our own IDE plugins). Wildcards in the .bazelignore file would give us a much nicer development experience in practice.

This creates a new `pnpm-workspace.yaml` which makes it install `node_modules/` in all the `packages/*` directories. This wasn't necessary before because `rules_prerender` and `@rules_prerender/declarative_shadow_dom` don't have any external dependencies, but it is necessary to install package-specific dependencies. Also updates `tsconfig.json` to work for any `@rules_prerender/*` packages instead of just `@rules_prerender/declarative_shadow_dom`. `.bazelignore` needs to be updated as well, but doesn't support globs unfortunately (see bazelbuild/bazel#7093). `node_modules/` verification was also incorrectly being done on the user `.bazelignore` file, rather than `@rules_prerender`'s `.bazelignore` when loaded as an external workspace. Used a `Label()` constructor to fix that.

chadxzs · 2023-04-05T20:11:16Z

My team would really appreciate this feature. We're having issues right now because we're running into "infinite symlink expansion detected" when Bazel traverses into .terraform directories due to the way we are structuring our terraform code. It would be nice to be able to add a global .terraform ignore to prevent Bazel from encountering this.

Additionally, we're running into the same sort of issue with the node_modules being problematic and having to add an ignore line for each instance of this in our monorepo.

If we do a broad .bazelignore for a whole subtree that may contain these files, the IntelliJ Plugin for Bazel ignores these paths in the project view, which causes these paths to be excluded from things like code search which we value.

dgoldstein0 · 2023-09-25T21:55:39Z

+1 to this.

Ran into this in the node_modules context, similar to @Toxaris, but probably a little simpler of a failure mode - rxjs is one dep of ours that uses some third party bazel rules, which crash any bazel queries that use ... over the folder after it's installed as we don't have the repositories it uses configured in our workspace.

I would love if .bazelignore worked more like .gitignore - e.g. support .gitignore syntax and/or support distributed .bazelignore files. (With the latter, we could make a yarn plugin that adds node_modules/.bazelignore whenever we yarn install - but the plugin approach obviously doesn't generalize to other folks' problems)

dgoldstein0 · 2024-06-26T19:57:10Z

any chance of getting this prioritized? seems like this would be an easy thing to fix and a good experience win for users of .bazelignore.

albertocavalcante · 2024-07-03T07:04:28Z

Hey! Is there any ongoing effort in getting this implemented?

armandomontanez · 2024-08-07T01:08:12Z

When working in a project that has parallel CMake support via ExternalProject_Add , it'd be really nice if I could just .bazelignore cmake-* to prevent Bazel from trying to pick up the build directories produced by CMake.

zbowling · 2024-08-14T17:16:50Z

Any updates?

David-Lam · 2024-08-14T22:40:37Z

Hi folks! Sorry I no longer have time to complete this. Please feel free to take a stab if interested. Thanks!

iirina added untriaged team-Bazel General Bazel product/strategy issues labels Jan 14, 2019

dslomov added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. and removed team-Bazel General Bazel product/strategy issues labels Jul 19, 2019

laurentlb added P3 We're not considering working on this, but happy to review a PR. (No assignee) type: feature request and removed untriaged labels Jul 26, 2019

moroten mentioned this issue Nov 16, 2019

Query @sub//... of local_repository fails because of including @sub//bazel-subdir/ #10255

Closed

gregmagolan mentioned this issue Feb 13, 2020

build: npm_integration_test && angular_integration_test angular/angular#33927

Closed

14 tasks

philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 15, 2020

Dkendal mentioned this issue May 7, 2021

chore: add basic bazel support BuilderIO/builder#465

Merged

David-Lam mentioned this issue Jul 27, 2021

Added wildcard feature to .bazelignore #13756

Closed

philwo removed the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Nov 29, 2021

aiuto mentioned this issue Jan 11, 2022

No way to tell .bazelignore to ignore all folders of the given name #8106

Closed

brentleyjones mentioned this issue Sep 16, 2022

Changing output base results in failed builds due to parsing the contents of the convenience symlinks #13951

Closed

jhchabran mentioned this issue Jan 26, 2023

bazel: build the //lib folder sourcegraph/sourcegraph-public-snapshot#46929

Merged

sushain97 mentioned this issue Jan 16, 2024

bazel crash on windows with java.nio.file.InvalidPathException: Illegal char <*> at index ... #20906

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FR] .bazelignore should support wildcard prefix #7093

[FR] .bazelignore should support wildcard prefix #7093

or-shachar commented Jan 11, 2019

ittaiz commented Jan 29, 2019

jupp0r commented Jan 17, 2020

gregmagolan commented Feb 13, 2020 •

edited

Loading

cgruber commented Feb 28, 2020

David-Lam commented Jul 27, 2021 •

edited

Loading

nkoroste commented Nov 18, 2021

guw commented Jan 11, 2022

Toxaris commented Jan 31, 2023 •

edited

Loading

chadxzs commented Apr 5, 2023

dgoldstein0 commented Sep 25, 2023

dgoldstein0 commented Jun 26, 2024

albertocavalcante commented Jul 3, 2024

armandomontanez commented Aug 7, 2024

zbowling commented Aug 14, 2024

David-Lam commented Aug 14, 2024

[FR] .bazelignore should support wildcard prefix #7093

[FR] .bazelignore should support wildcard prefix #7093

Comments

or-shachar commented Jan 11, 2019

Description of the feature request:

What operating system are you running Bazel on?

ittaiz commented Jan 29, 2019

jupp0r commented Jan 17, 2020

gregmagolan commented Feb 13, 2020 • edited Loading

cgruber commented Feb 28, 2020

David-Lam commented Jul 27, 2021 • edited Loading

nkoroste commented Nov 18, 2021

guw commented Jan 11, 2022

Toxaris commented Jan 31, 2023 • edited Loading

chadxzs commented Apr 5, 2023

dgoldstein0 commented Sep 25, 2023

dgoldstein0 commented Jun 26, 2024

albertocavalcante commented Jul 3, 2024

armandomontanez commented Aug 7, 2024

zbowling commented Aug 14, 2024

David-Lam commented Aug 14, 2024

gregmagolan commented Feb 13, 2020 •

edited

Loading

David-Lam commented Jul 27, 2021 •

edited

Loading

Toxaris commented Jan 31, 2023 •

edited

Loading