Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.28 - July 2019 (stable) #8571

Closed
dslomov opened this issue Jun 6, 2019 · 14 comments
Closed

Release 0.28 - July 2019 (stable) #8571

dslomov opened this issue Jun 6, 2019 · 14 comments
Assignees
Labels

Comments

@dslomov
Copy link
Contributor

dslomov commented Jun 6, 2019

Target RC date - July 1st, 2019
This release will have no breaking changes.

See the blog post for some details

@dslomov dslomov added the release label Jun 6, 2019
@dslomov dslomov changed the title Release 0.28 - July 2019 Release 0.28 - July 2019 (stable) Jun 6, 2019
@laszlocsomor laszlocsomor pinned this issue Jun 27, 2019
@laurentlb laurentlb assigned laurentlb and unassigned philwo Jul 2, 2019
@laurentlb
Copy link
Contributor

laurentlb commented Jul 2, 2019

Status of Bazel 0.28

I plan to keep this message up to date during the release process and provide the important information.

To report a release-blocking bug: file a bug, use the Release blocker label, and cc @laurentlb. Release blockers are regressions in Bazel relative to Bazel 0.26 or Bazel 0.27.

Task list:

@bazelbuild bazelbuild deleted a comment from hlopko Jul 2, 2019
@bazelbuild bazelbuild deleted a comment from dslomov Jul 2, 2019
@bazelbuild bazelbuild deleted a comment from dslomov Jul 2, 2019
@bazelbuild bazelbuild deleted a comment from hlopko Jul 2, 2019
@laszlocsomor
Copy link
Contributor

Please cherry-pick 6d0b14b to fix 0.26 -> 0.27 regression #8723. See also #7816 (comment)

@laurentlb
Copy link
Contributor

0.28.0rc2 was created using:
scripts/release/release.sh create --force_rc=2 0.28.0 2e374a9 6d0b14b

The binaries are available here: https://releases.bazel.build/0.28.0/rc2/index.html

@laurentlb
Copy link
Contributor

@jin
Copy link
Member

jin commented Jul 11, 2019

0.28.0 introduced a breaking change with the behavior of --experimental_google_legacy_api.

To reproduce, clone https://github.com/bazelbuild/intellij and run bazel build //aswb:aswb_bazel_zip --define=ij_product=android-studio-beta.

0.28.0:

jingwen@jingwen-sea:~/code/intellij$ USE_BAZEL_VERSION=0.28.0 bazel build //aswb:aswb_bazel_zip --define=ij_product=android-studio-beta --nobuild
ERROR: /usr/local/google/home/jingwen/code/intellij/aspect/intellij_info_impl.bzl:105:25: android_common is experimental and thus unavailable with the current flags. It may be enabled by setting --experimental_google_legacy_api
ERROR: /usr/local/google/home/jingwen/code/intellij/aswb/BUILD:212:1: error loading package 'aspect': Extension 'aspect/intellij_info_impl.bzl' has errors and referenced by '//aswb:aspect_directory'
ERROR: Analysis of target '//aswb:aswb_bazel_zip' failed; build aborted: Analysis failed
INFO: Elapsed time: 0.200s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded, 0 targets configured)
    currently loading: java ... (3 packages)

0.27.2:

jingwen@jingwen-sea:~/code/intellij$ USE_BAZEL_VERSION=0.27.2 bazel build //aswb:aswb_bazel_zip --define=ij_product=android-studio-beta --nobuild
WARNING: Waiting for server process to terminate (waited 5 seconds, waiting at most 60)
Starting local Bazel server and connecting to it...
INFO: Analyzed target //aswb:aswb_bazel_zip (59 packages loaded, 2137 targets configured).
INFO: Found 1 target...
INFO: Deleting stale sandbox base /usr/local/google/home/jingwen/.cache/bazel/_bazel_jingwen/566de91536493bd30d1fb02c05327dbd/sandbox
INFO: Elapsed time: 10.472s
INFO: 0 processes.
INFO: Build completed successfully, 0 total actions

This affects all Bazel 0.28.0 users using any of the stable IntelliJ plugins.

cc @c-parsons

78e5fe2 is the breaking change for android_common. We should either rollback this change, or rollforward by whitelisting android_common. It's not feasible to ask all IntelliJ users to add --experimental_google_legacy_api.

I'll take on an action item to expand the IntelliJ CI coverage to ensure that this doesn't happen again: bazelbuild/intellij#977

Update: please cherry pick a0af170 into 0.28.0.

@meteorcloudy
Copy link
Member

@laurentlb 7d2bc7e caused a bug which was caught internally, 2260b97 is the fix, but it's not in 0.28.0. Please cheery-pick 2260b97 if you're releasing 0.28.1.

Related #8707

@meteorcloudy
Copy link
Member

@laurentlb Please cherry-pick c6ca6c2 to fix regression reported at #3857 (comment)

@laurentlb
Copy link
Contributor

Created 0.28.1 with:
scripts/release/release.sh create 0.28.1 18cd904 2260b97 a0af170 c6ca6c2

You can download it from: https://releases.bazel.build/0.28.1/rc1/index.html

dwtj pushed a commit to dwtj/ex_clion_bazel_plugin_gdb_timeout that referenced this issue Jul 17, 2019
- Updated to latest version of protobuf, v3.9.0.
- Added `@bazel_skylib` external/workspace dependency. (Seems to be
needed for protobuf.)
- Applied the Bazel v0.28.0 bug workaround described [here](bazelbuild/bazel#8571 (comment)).
(This shouldn't be necessary after the next bazel release.)
@jin
Copy link
Member

jin commented Jul 18, 2019

Users are starting to report issues with the IntelliJ plugin: bazelbuild/intellij#976 (comment)

Could we expedite promoting 0.28.1rc1 to a release?

@laurentlb
Copy link
Contributor

Released: https://github.com/bazelbuild/bazel/releases/tag/0.28.1

@ulfjack
Copy link
Contributor

ulfjack commented Jul 19, 2019

The release notes are messed up:

This release contains contributions from many people at Google, as well as .

The sentence is incomplete. Did something go wrong with the release script?

@ulfjack
Copy link
Contributor

ulfjack commented Jul 19, 2019

The release notes link for 0.28.0 contains a link to the pull request for the release notes, rather than a link to the blog post.

@laurentlb
Copy link
Contributor

Thanks, release descriptions on GitHub have been fixed.

@dstiers-1109
Copy link

Thank you

@dslomov dslomov unpinned this issue Sep 2, 2019
@dslomov dslomov closed this as completed Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants