Windows: windows_remote_test fails with --incompatible_windows_native_test_wrapper

[laszlocsomor]

Windows 10
Bazel 0.28.1

//src/test/py/bazel:windows_remote_test fails with --incompatible_windows_native_test_wrapper :

exec ${PAGER:-/usr/bin/less} "$0" || exit 1
Executing tests from //src/test/py/bazel:windows_remote_test
-----------------------------------------------------------------------------
.C:\python3\lib\unittest\suite.py:107: ResourceWarning: unclosed file <_io.BufferedRandom name=3>
  for index, test in enumerate(self):
C:\python3\lib\unittest\suite.py:107: ResourceWarning: unclosed file <_io.BufferedRandom name=4>
  for index, test in enumerate(self):
....F
======================================================================
FAIL: testShTestRunsRemotely (__main__.WindowsRemoteTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "\\?\D:\temp\Bazel.runfiles_v5_7ny3c\runfiles\io_bazel\src\test\py\bazel\windows_remote_test.py", line 139, in testShTestRunsRemotely
    self.assertIn('RUNFILES_MANIFEST_FILE: ""', stdout)
AssertionError: 'RUNFILES_MANIFEST_FILE: ""' not found in ['==================== Test output for //foo:foo_test:', 'hello test', 'RUNFILES_MANIFEST_FILE: "D:/temp/build-d474d29e-f9b9-46ea-b31d-e75a5d46c2f6/bazel-out/x64_windows-fastbuild/bin/foo/foo_test.exe.runfiles/MANIFEST"', '================================================================================', '//foo:foo_test                                                           PASSED in 0.2s', '', 'Executed 1 out of 1 test: 1 test passes.', 'There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.']

----------------------------------------------------------------------
Ran 6 tests in 188.195s

Full log: https://buildkite.com/bazel/bazel-bazel-github-presubmit/builds/3833#9aef8611-6633-4d18-9012-3d17e507deb3

[laszlocsomor]

I think the culprit is

bazel/tools/test/windows/tw.cc

Line 527 in 019586a

!SetPathEnv(L"RUNFILES_MANIFEST_FILE", runfiles_mf)) {

.

The test wrapper should check if the manifest exists before exporting it, like test-setup.sh does:

bazel/tools/test/test-setup.sh

Line 131 in 019586a

if [[ "${RUNFILES_MANIFEST_ONLY:-}" == "1" && -e "${RUNFILES_MANIFEST_FILE:-}" ]]; then

[laszlocsomor]

The test wrapper should check if the manifest exists before exporting it

That is indeed the culprit. I'll fix that.

However, RUNFILES_MANIFEST_ONLY=1 while RUNFILES_DIR has a value (in testShTestRunsRemotely). Looks like a bug.