Reintroduce support for Python 2.6 to python_stub_template #11269
Conversation
Commit d5012a7 introduced a Python 2.7 dependency into python_stub_template.txt. Unfortunately this stub is non-hermetic, so even if the user has configured Python 2.7 and 3 `py_runtime`s, their builds may fail if the system-provided Python is ancient (ex: CentOS 6.6 provides Python 2.6.6). Accommodate ancient Python by reworking the path deduplication in terms of a `set` and a generator instead of `collections.OrderedDict`. Workaround for #11265. Testing Done: - `bazelisk test //src/test/shell/integration:python_stub_test` - In a CentOS 6.6 env: ```console $ /usr/bin/env python -V Python 2.6.6 $ cat >test.py <<EOF import sys print(sys.executable) EOF $ cat >BUILD <<EOF py_binary(name = "test", srcs = ["test.py"]) EOF $ bazel run :test /path/to/my/hermetic/python3 ```
|
@brandjon Since it is already the weekend for Jin, I'll cover here. If you do the approve, I've got the patch CL lined up. |
|
I'm a little reluctant to do this, because it sets a precedent that we want to support Python 2.6 (released about 12 years ago) in the stub script. If that's going to be a requirement then we should arguably include a Python 2.6 interpreter in our test environment and run at least one It also may be unnecessary if we instead add the ability to select an alternate stub script shebang in the Python toolchain. See #8685. But I appreciate that in the absence of a shebang-selecting feature in the toolchain, this PR is useful and is anyway harmless. How about we accept this patch and just add a comment reminding to keep compatibility with Python 2.6 until #8685 is implemented. |
|
(Added comment clarifying this stance in the internal merge.) |
|
Great, thanks! |
ghost
deleted the
ghost
mentioned this pull request
Commit d5012a7 introduced a Python
2.7 dependency into python_stub_template.txt. Unfortunately this stub
is non-hermetic, so even if the user has configured Python 2.7 and 3
py_runtimes, their builds may fail if the system-provided Python is ancient(ex: CentOS 6.6 provides Python 2.6.6).
Accommodate ancient Python by reworking the path deduplication in terms
of a
setand a generator instead ofcollections.OrderedDict.Workaround for #11265.
Testing Done:
bazelisk test //src/test/shell/integration:python_stub_test