Update error prone version to 2.3.4

[davido]

Fixes #11272 (first attempt that was reverted: #9286).

[davido]

We are trying to activate additional error prone checks in Gerrit build: [1]. For this purpose I've conducted a new release for java_tools with new error prone version and published it here: [2]. Finally in this CL: [3] we are trying to switch using custom java_tools with bumped error prone version.

While doing this, we are running into multiple issues: [4] and: [5].

[5] is particularly annoying, because I have to specify java_toolchain to switch to custom java_tools release. But given that java_tools distribution contains native code, we cannot just add yet another fancy option to the WORKSPACE/.bazelrc file, and can only document to use different options on different platforms:

To build on Linux please do this:

  $ bazel build \
    --java_toolchain=@remote_java_tools_linux//:toolchain \
    --host_java_toolchain=@remote_java_tools_linux//:toolchain \
    :release

To build on Mac Os X please do that:

  $ bazel build \
    --java_toolchain=@remote_java_tools_darwin//:toolchain \
    --host_java_toolchain=@remote_java_tools_darwin//:toolchain \
    :release

[1] https://gerrit-review.googlesource.com/c/gerrit/+/235098
[2] https://github.com/davido/java_tools/releases/tag/javac11-v11.0
[3] https://gerrit-review.googlesource.com/c/gerrit/+/265493/4
[4] #8268
[5] #10031

//CC @cushon @meisterT.

[meisterT]

Yun, can you please have a look how this ties into your Debian efforts?

[meteorcloudy]

LGTM

This library is not in Debian anyway. And it's better to depend on a formal version instead of a snapshot.

[davido]

@meteorcloudy @meisterT Thanks for the feedback. Note, though, that this PR also adds new dependency to Bazel: Ben-Manes caffeine library: [1]. By chance I know, that Gerrit is also relying on the same version: 2.7.0, so that it should be already imported in Google's Monorepo.

But is there any special procedure/process to include new third party dependency in Bazel?

[1] https://github.com/ben-manes/caffeine

[meteorcloudy]

Oh.. I see. Thanks for the notice. I checked the caffeine library is not in Debian. So this will add more difficulties for the effort of getting Bazel into Debian. Check #9408

Is it because the new error prone version requires this library? Besides, the checked in version is 2.8.0 in Google.

[meisterT]

David, how large is the new dependency?

[davido]

Is it because the new error prone version requires this library?

Sure. The dependency was added in EP tree in this CL: [1] and was updated to 2.7.0 in this CL: [2].

David, how large is the new dependency?

It's 846706 bytes:

$ wget https://repo1.maven.org/maven2/com/github/ben-manes/caffeine/caffeine/2.7.0/caffeine-2.7.0.jar
--2020-05-04 10:50:49--  https://repo1.maven.org/maven2/com/github/ben-manes/caffeine/caffeine/2.7.0/caffeine-2.7.0.jar
Connecting to 16.175.95.22:8080... connected.
Proxy request sent, awaiting response... 200 OK
Length: 846706 (827K) [application/java-archive]
Saving to: ‘caffeine-2.7.0.jar’

caffeine-2.7.0.jar                       100%[==================================================================================>] 826,86K  --.-KB/s    in 0,1s

2020-05-04 10:50:49 (5,45 MB/s) - ‘caffeine-2.7.0.jar’ saved [846706/846706]

[1] google/error-prone@bfb1789
[2] google/error-prone@f0428b2

[davido]

Besides, the checked in version is 2.8.0 in Google.

@meteorcloudy Thanks for checking!

I have sent this PR: [1] to sync Caffeine version in EP tree to 2.8.0.

UPDATE Let's wait, if my PR: [1] is approved in EP, I will update this PR and bump Caffeine library to 2.8.0.

[1] google/error-prone#1602

[davido]

@meteorcloudy

Besides, the checked in version is 2.8.0 in Google.

My PR: [1] was merged in EP, so that I will adapt this PR correspondingly.

[1] google/error-prone#1602

[davido]

My PR: [1] was merged in EP, so that I will adapt this PR correspondingly.

Done.

[davido]

Superseded by #11426.