Add embedded jdk support for s390x #11865
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch follows a similar approach used in PR bazelbuild#11436 to add support for embedding OpenJDK in bazel on s390x. Similar to ppc, the openjdk used will be downloadded from adoptopenjdk website. Another thing this PR does is to provide the cached version of allmodules_jdk and minimal_jdk zip files built on s390x. I have tested by linking the files locally on s390x and with these zip files provided, tests no longer fail with java exec format error on s390x.
|
Hello, Not sure if it is the correct place to ask this, but wondering if there is additional steps I should take or look into to request for a code review? Happy to make change and discuss. Thanks |
|
Hi @ruixin-bao, happy to review this, but I’m on vacation this week - will get to it next week! Sorry for the delay! I’ll reopen this, ok? |
|
Hi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch follows a similar approach used in PR
#11436 to add support
for embedding OpenJDK in bazel on s390x.
Similar to ppc, the openjdk used will be downloadded from adoptopenjdk website.
Thank you for the help!