Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix races in the HTTP upload and download handlers #12055

Closed
wants to merge 1 commit into from
Closed

Fix races in the HTTP upload and download handlers #12055

wants to merge 1 commit into from

Commits on Sep 5, 2020

  1. Fix races in the HTTP upload and download handlers 

    The user promise has a callback that returns the connection to the pool.
If the server returns a 'connection: close' HTTP header, then this can
currently happen before the connection is closed, in which case the client
attempts to reuse the connection, which - of course - fails.

This changes the ordering to close the connection *before* completing the
user promise.

This is at least a partial fix for the linked issue. It is unclear if this
is the root cause for all the reported failure modes.

Progress on bazelbuild#10159.

Change-Id: I2897e55c6edda592a6fb5755ddcccd1a89cde528
    @ulfjack
    ulfjack committed Sep 5, 2020
    Configuration menu
    Copy the full SHA
    5e7c7f7 View commit details
    Browse the repository at this point in the history