Set java_runtime on java_toolchains. #12333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toolchains that don't have java_runtime in a remote repository (toolchain_hostjdk8, legacy_toolchain, ...) were removed. They are better defined using java_toolchain_default, next to the rules defining local JDK.
|
Downstream tests in https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1721 |
katre
reviewed
Oct 22, 2020
| @@ -648,7 +656,7 @@ JAVA_VERSIONS = ("11",) | |||
| name = "create_java_tools_build_java" + java_version, | |||
| srcs = ["//tools/jdk:BUILD.java_tools"], | |||
| outs = ["remote_java_tools_java" + java_version + "/BUILD"], | |||
| cmd = "sed 's/JAVA_LANGUAGE_LEVEL/" + java_version + "/g' $< > $@", | |||
| cmd = "sed 's/JAVA_LANGUAGE_LEVEL/" + java_version + "/g; s/PLATFORM/" + _PLATFORM + "/g' $< > $@", | |||
There was a problem hiding this comment.
My read of this is that only the remote JDK that matches the host platform will be generated. Is this the intended use?
There was a problem hiding this comment.
I updated the comment.
|
Exactly. This is the default setting that always works. In case you want to
compile using local JDK, the right place to define java_toolchain is in
local_java_repository or in WORKSPACE file.
On Thu 22. Oct 2020 at 20:36, katre ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/BUILD
<#12333 (comment)>:
> @@ -648,7 +656,7 @@ JAVA_VERSIONS = ("11",)
name = "create_java_tools_build_java" + java_version,
srcs = ["//tools/jdk:BUILD.java_tools"],
outs = ["remote_java_tools_java" + java_version + "/BUILD"],
- cmd = "sed 's/JAVA_LANGUAGE_LEVEL/" + java_version + "/g' $< > $@",
+ cmd = "sed 's/JAVA_LANGUAGE_LEVEL/" + java_version + "/g; s/PLATFORM/" + _PLATFORM + "/g' $< > $@",
My read of this is that only the remote JDK that matches the host platform
will be generated. Is this the intended use?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#12333 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANWREBVR4GHXBX673ODDVLSMB3SLANCNFSM4S3F66MA>
.
--
Ivo List | Software Engineer | ilist@google.com |
|
|
That makes sense to me, but it's worth calling out the behavior in a comment. |
katre
approved these changes
Oct 22, 2020
bazel-io
pushed a commit
that referenced
this pull request
Oct 27, 2020
*** Reason for rollback *** Setting java_runtime attribute on java_toolchain before bazel is released doesn't work, because @remote_java_tools_linux_for_testing (and others) are loaded with old bazel release. *** Original change description *** Set java_runtime on java_toolchains. Toolchains that don't have java_runtime in a remote repository (toolchain_hostjdk8, legacy_toolchain, ...) were removed. They are better defined using java_toolchain_default, next to the rules defining local JDK. Closes #12333. PiperOrigin-RevId: 339218931
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toolchains that don't have java_runtime in a remote repository (toolchain_hostjdk8, legacy_toolchain, ...) were removed. They are better defined using java_toolchain_default, next to the rules defining local JDK.