Use release_archive to create java_tools' zips. #12615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meteorcloudy
requested changes
Dec 4, 2020
meteorcloudy
approved these changes
Dec 4, 2020
comius
added a commit
to comius/bazel
that referenced
this pull request
Dec 4, 2020
comius
added a commit
to comius/bazel
that referenced
this pull request
Dec 4, 2020
comius
added a commit
to comius/bazel
that referenced
this pull request
Dec 7, 2020
This is third part of bazelbuild#12615 Second part was bazelbuild#12628
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing a release_archive macro, referring to https://github.com/bazelbuild/rules_kotlin/blob/master/kotlin/internal/utils/packager.bzl, however using shells scripts instead of importing @rules_pkg.
Previous implementation had a problem, because there is no sandbox on windows. genrules renaming BUILD files have overwritten main BUILD file when creating Bazel distribution.
Fixes #12578