Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose JacocoRunner from JavaToolchain to Starlark. #12829

Closed
wants to merge 1 commit into from
Closed

Expose JacocoRunner from JavaToolchain to Starlark. #12829

wants to merge 1 commit into from

Conversation

comius
Copy link
Contributor

@comius comius commented Jan 14, 2021

Issue #11674

@comius comius requested a review from c-mita January 14, 2021 11:14
@google-cla google-cla bot added the cla: yes label Jan 14, 2021
@jin jin added the team-Rules-Java Issues for Java rules label Jan 15, 2021
c-mita
c-mita approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@c-mita c-mita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bazel-io bazel-io closed this in bbac0c3 Jan 18, 2021
@gergelyfabian gergelyfabian mentioned this pull request Jan 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-mita c-mita c-mita approved these changes

Assignees

@comius comius

Labels
cla: yes team-Rules-Java Issues for Java rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@comius @c-mita @jin