Bazel's filegroup should participate in toolchain resolution.

[katre]

This reverts dce861d, which was a
mistake.

It also removes a test which is now useless. There are no more build
rules (which have the target_compatible_with attribute for target
skipping) which also have toolchain resolution disabled, so this cannot
be tested for.

Fixes #12899 and undoes #13194.

[katre]

@philsc thanks for pointing out that this change was a mistake. I'm removing the test that caused my confusion.

[gregestren]

What was the full context here (losing all the threads in my inbox)? Being able to use select in filegroup?

[katre]

Originally, #12899 was filed because selects in filegroup worked, except for selects using constraint values. I fixed this by enabling toolchain resolution for filegroup.

Then, last week, I noticed that

• We have tests that assume filegroup does not take part in toolchain resolution, and
• The internal version of filegroup and the external version deviate on this.

I picked the fix the make them both not take part in toolchain resolution, forgetting about #12899. That, unfortunately, regressed that issue, so now I am reverting that change (and removing a useless test).

The test is useless because it was testing whether a build rule (therefore, one that can use target_compatible_with for target skipping) that had toolchain resolution disabled work work properly. However, with this change to filegroup, there are no remaining build rules that have toolchain resolution disabled, so this isn't a valid state.

[gregestren]

Makes sense. Thanks so much for the clarification.