Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Jacoco to 0.8.6 and asm to 9.1 #13322

Closed
wants to merge 4 commits into from

Conversation

comius
Copy link
Contributor

@comius comius commented Apr 9, 2021

Fixes #11674

@comius comius self-assigned this Apr 9, 2021
@google-cla google-cla bot added the cla: yes label Apr 9, 2021
@comius comius requested a review from philwo April 9, 2021 14:37
@comius comius marked this pull request as ready for review April 9, 2021 14:37
@comius
Copy link
Contributor Author

comius commented Apr 9, 2021

This requires a complicated dance of 3 PRs: first add second jacoco to third_party, second use it everywhere, third remove the second jacoco from third_party. @philwo what do you think about merging this first directly and then submitting it over copybara? Or will copybara go crazy?

@comius comius marked this pull request as draft April 12, 2021 07:08
@davido
Copy link
Contributor

davido commented Apr 14, 2021

This was merged already?

@comius comius closed this Apr 14, 2021
@comius
Copy link
Contributor Author

comius commented Apr 14, 2021

This was merged already?

Yes, in 4 other (different) PRs to handle copybara.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Jacoco to 0.8.5+ to fix Scala 2.12 lambda code coverage
2 participants