Fix Windows developer mode symlinks #13629
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meteorcloudy
reviewed
Jul 1, 2021
| @@ -467,6 +463,13 @@ int CreateSymlink(const wstring& symlink_name, const wstring& symlink_target, | |||
|
|
|||
| if (!CreateSymbolicLinkW(name.c_str(), target.c_str(), | |||
| symlinkPrivilegeFlag)) { | |||
| if (GetLastError() == ERROR_INVALID_PARAMETER) { | |||
There was a problem hiding this comment.
Nit: This means on older Windows versions with developer mode enabled, each symlink operation triggers CreateSymlinkLink twice, which has some performance implication. But I guess it's small issue which won't impact the vast majority of Windows users.
meteorcloudy
approved these changes
Jul 1, 2021
|
Thanks for the fix! |
katre
pushed a commit
to katre/bazel
that referenced
this pull request
Jul 13, 2021
The OS version check in bazelbuild#13488 breaks the developer mode symlink behavior. `IsWindowsVersionOrGreater` does not work as advertised, and returns false on Windows 10 if not called from an executable with an associated application manifest declaring its compatibility for Windows 10. (Very cool, Microsoft.) The other methods of checking OS version are far more verbose and complicated, which doesn't seem warranted here. As an alternative workaround, this PR replaces the ahead-of-time version check with a retry without the flag if the function reports an invalid argument exception. @meteorcloudy Closes bazelbuild#13629. PiperOrigin-RevId: 382734470
katre
pushed a commit
to katre/bazel
that referenced
this pull request
Jul 13, 2021
The OS version check in bazelbuild#13488 breaks the developer mode symlink behavior. `IsWindowsVersionOrGreater` does not work as advertised, and returns false on Windows 10 if not called from an executable with an associated application manifest declaring its compatibility for Windows 10. (Very cool, Microsoft.) The other methods of checking OS version are far more verbose and complicated, which doesn't seem warranted here. As an alternative workaround, this PR replaces the ahead-of-time version check with a retry without the flag if the function reports an invalid argument exception. @meteorcloudy Closes bazelbuild#13629. PiperOrigin-RevId: 382734470
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OS version check in #13488 breaks the developer mode symlink behavior.
IsWindowsVersionOrGreaterdoes not work as advertised, and returns false on Windows 10 if not called from an executable with an associated application manifest declaring its compatibility for Windows 10. (Very cool, Microsoft.) The other methods of checking OS version are far more verbose and complicated, which doesn't seem warranted here.As an alternative workaround, this PR replaces the ahead-of-time version check with a retry without the flag if the function reports an invalid argument exception.
@meteorcloudy