Update default stub shebang to Python 3 #13851
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @olekw, thanks! I have the same change pending internally and already LGTM'd from my colleague, but I'm still trying to fix that one test on Windows that's failing... I just gave it another try, let's see how it goes. I'll mark this PR as fixed once my change is submitted! |
|
The Windows version of Python doesn't ship a I'm going to fix this with |
apattidb
pushed a commit
to databricks/bazel
that referenced
this pull request
May 27, 2022
This reflects the change in recent Linux distributions that no longer ship a /usr/bin/python binary. I'm not sure where this is actually used, now that if I understand correctly the shebang defaults to the Python binary found via auto-detection, but we should probably still fix this path (or remove this default fallback completely?). Related to bazelbuild#11201. Closes bazelbuild#13851. PiperOrigin-RevId: 392427248
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last part of #11201.
@philwo