Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim input build settings after transition #13971

Closed
wants to merge 1 commit into from
Closed

Trim input build settings after transition #13971

wants to merge 1 commit into from

Commits on Sep 28, 2021

  1. Trim input build settings after transition 

    By convention, BuildOptions should not contain Starlark build settings
that are set to their default values. However, if a Starlark transition
has a build setting as an input, the value of that setting has to be
added to the input BuildOptions temporarily so that it can be read by
the transition.

Before this commit, if a build setting was an input but not an output of
a transition, its default value remained in the BuildOptions and could
cause action conflicts. With this commit, all build settings rather than
only output build settings are trimmed post-transition if they are set
to their default value.

Fixes bazelbuild#12888.
    @fmeum
    fmeum committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    c417fe3 View commit details
    Browse the repository at this point in the history